agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Ron Mayer <rm_pg@cheapcomplexdevices.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Markus Wanner <markus@bluegap.ch>
Cc: Ron Mayer <rm_pg@cheapcomplexdevices.com>
Cc: Marko Kreen <markokr@gmail.com>
Cc: Greg Stark <stark@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Aidan Van Dyk <aidan@highrise.ca>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PostgreSQL Developer meeting minutes up
Date: Mon, 08 Jun 2009 01:56:51 -0700
Message-ID: <4A2CD253.1000903@cheapcomplexdevices.com> (raw)
In-Reply-To: <603c8f070906050920h6842bf91q6ef2ec22e2948eb0@mail.gmail.com>
References: <20090526144812.GC15213@yugib.highrise.ca>
<e51f66da0906030720u33d72d05y14ea5ce002cbaf1e@mail.gmail.com>
<20090604114610.808217tbogts0noi@mail.bluegap.ch>
<4A283A8D.8030600@cheapcomplexdevices.com>
<20090605090514.11712ntlvhi2deay@mail.bluegap.ch>
<2871.1244209112@sss.pgh.pa.us>
<603c8f070906050829m1eaaa969tff7ca85d04018c5a@mail.gmail.com>
<4888.1244216273@sss.pgh.pa.us>
<603c8f070906050859t41595fb1n17ed6084711b542e@mail.gmail.com>
<5543.1244218518@sss.pgh.pa.us>
<603c8f070906050920h6842bf91q6ef2ec22e2948eb0@mail.gmail.com>
Robert Haas wrote:
> On Fri, Jun 5, 2009 at 12:15 PM, Tom Lane<tgl@sss.pgh.pa.us> wrote:
>> ... but I'm not at all excited about cluttering the
>> long-term project history with a zillion micro-commits. One of the
>> things I find most annoying about reviewing the current commit history
>> is that Bruce has taken a micro-commit approach to managing the TODO
>> list --- I was seldom so happy as the day that disappeared from CVS,
>> because of the ensuing reduction in noise level.
For better or worse, git also includes a command "git-rebase" that can
collapse such micro-commits into a larger one.
Quoting the git-rebase man page:
A range of commits could also be removed with rebase. If we have the
following situation:
E---F---G---H---I---J topicA
then the command
git-rebase --onto topicA~5 topicA~3 topicA
would result in the removal of commits F and G:
E---H´---I´---J´ topicA
While I wouldn't recommend using this for historical revisionism, I
imagine it could be useful during code-review time when the
micro-commits (from both the patch submitter and patch reviewer)
are interesting. After the review, the commits could be collapsed
into meaningful-sized-chunks just before they're merged into the
official branches.
view thread (84+ messages) latest in thread
Message-ID: <4A2CD253.1000903@cheapcomplexdevices.com>
Permalink: ../../4A2CD253.1000903@cheapcomplexdevices.com/
Also on: postgresql.org/message-id/4A2CD253.1000903@cheapcomplexdevices.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rm_pg@cheapcomplexdevices.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, markus@bluegap.ch, markokr@gmail.com, stark@enterprisedb.com, andres@anarazel.de, aidan@highrise.ca, heikki.linnakangas@enterprisedb.com, magnus@hagander.net, andrew@dunslane.net
Subject: Re: PostgreSQL Developer meeting minutes up
In-Reply-To: <4A2CD253.1000903@cheapcomplexdevices.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox