Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 90129633C4E for ; Wed, 10 Jun 2009 15:55:06 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 52331-02 for ; Wed, 10 Jun 2009 15:55:03 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from alexis.jtlnet.com (alexis.jtlnet.com [69.36.9.81]) by mail.postgresql.org (Postfix) with ESMTP id 9904263340C for ; Wed, 10 Jun 2009 15:55:03 -0300 (ADT) Received: from [192.168.10.103] (cpe-075-177-154-027.nc.res.rr.com [::ffff:75.177.154.27]) (TLS: TLSv1/SSLv3,256bits,AES256-SHA) by alexis.jtlnet.com with esmtp; Wed, 10 Jun 2009 14:54:50 -0400 id 0008075D.4A30017B.000013E5 Message-ID: <4A30017D.5000309@dunslane.net> Date: Wed, 10 Jun 2009 14:54:53 -0400 From: Andrew Dunstan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text SeaMonkey/1.0.9 MIME-Version: 1.0 To: Tom Lane CC: Bruce Momjian , PostgreSQL-development Subject: Re: pgindent run coming References: <200906101824.n5AIOcV21199@momjian.us> <10593.1244658590@sss.pgh.pa.us> In-Reply-To: <10593.1244658590@sss.pgh.pa.us> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200906/790 X-Sequence-Number: 139845 Tom Lane wrote: > Bruce Momjian writes: > >> I am unclear why struct pointers are not being formatted properly in >> function headers but will research it. >> > > Yeah, if we can fix that directly without adding the names to the > typedef list, it would be better. But not something to do right now. > > Have you started the pgindent run yet? I have a patch ready for > the cursor stability issue, but will hold off committing if it might > create a merge problem for you. > > > I am doing runs as requested on various platforms to extract the typedef lists. Linux is done, Windows (mingw) is running, FBSD and Cygwin to come. Results in a few hours. The buildfarm will have a consolidated list. cheers andrew