Message-ID: <4A3005C1.7070700@dunslane.net>
Date: Wed, 10 Jun 2009 15:13:05 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text
	SeaMonkey/1.0.9
MIME-Version: 1.0
To: Bruce Momjian <bruce@momjian.us>
CC: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pgindent run coming
References: <200906101904.n5AJ44Z26240@momjian.us>
In-Reply-To: <200906101904.n5AJ44Z26240@momjian.us>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Bruce Momjian wrote:
> I did a diff, attached, and found some typedefs that don't appear, like
> PortalData.  That is defined in our code as:
>
> 	typedef struct PortalData *Portal;
> 	
> 	typedef struct PortalData
> 	{
> 	    /* Bookkeeping data */
> 	...
> 	    bool        visible;        /* include this portal in pg_cursors? */
> 	} PortalData;
>
> I will try to build on Linux here and see how objdump displays that,
> unless you can get me the output.
>   


Well, that is almost certainly a result of the change you asked me to 
make :-)

The symbol is in the run done early this morning before those changes. 
See 
<http://www.pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=dungbeetle&dt=2009-06-10%20064401&stg=typedefs>

So we need to look and see what tag that symbol has in the objdump output.

cheers

andrew