Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 1AFE1634708 for ; Sat, 13 Jun 2009 10:34:08 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 28950-10 for ; Sat, 13 Jun 2009 10:33:56 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from alexis.jtlnet.com (alexis.jtlnet.com [69.36.9.81]) by mail.postgresql.org (Postfix) with ESMTP id B4A6D634455 for ; Sat, 13 Jun 2009 10:34:04 -0300 (ADT) Received: from [192.168.10.103] (cpe-075-177-154-027.nc.res.rr.com [::ffff:75.177.154.27]) (TLS: TLSv1/SSLv3,256bits,AES256-SHA) by alexis.jtlnet.com with esmtp; Sat, 13 Jun 2009 09:33:34 -0400 id 0008074B.4A33AAAF.00006B19 Message-ID: <4A33AAC7.2000008@dunslane.net> Date: Sat, 13 Jun 2009 09:33:59 -0400 From: Andrew Dunstan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text SeaMonkey/1.0.9 MIME-Version: 1.0 To: Peter Eisentraut CC: pgsql-hackers@postgresql.org, Tom Lane , Bruce Momjian Subject: Re: pgindent run coming References: <200906101950.n5AJoFP01545@momjian.us> <200906102344.53483.peter_e@gmx.net> <13137.1244667281@sss.pgh.pa.us> <200906131613.53870.peter_e@gmx.net> In-Reply-To: <200906131613.53870.peter_e@gmx.net> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.084 tagged_above=0 required=5 tests=AWL=0.084 X-Spam-Level: X-Archive-Number: 200906/904 X-Sequence-Number: 139959 Peter Eisentraut wrote: > On Wednesday 10 June 2009 23:54:41 Tom Lane wrote: > >> Peter Eisentraut writes: >> >>>>> I think it usually does that already ... >>>>> >>> Um, attached you will find a bunch of counterexamples. >>> >> At a quick look, I'm not sure that any of these are in code that hasn't >> been edited since the 8.3 pgindent run. >> > > So what does that mean then? Surely pgindent doesn't keep track of what has > been edited when? > > If the code has been edited since the last pgindent run, then pgindent hasn't had a chance to adjust it, no? cheers andrew