pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedAnonymous code blocks (was: Re: GRANT ON ALL IN schema)
3+ messages / 3 participants
[nested] [flat]
* Anonymous code blocks (was: Re: GRANT ON ALL IN schema)
@ 2009-08-28 23:39 Petr Jelinek <pjmodos@pjmodos.net>
0 siblings, 1 reply; 3+ messages in thread
From: Petr Jelinek @ 2009-08-28 23:39 UTC (permalink / raw)
To: pgsql-hackers; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Alvaro Herrera <alvherre@commandprompt.com>
> The question is still valid, though it's better put in your words - do
> we want to refactor the existing compiler or write a separate one ?
So, for now I went with the path of custom compiler and current executor.
I attached current version of the patch. I don't expect this to get
committed or anything, but I'd like other eyes to take a look at it.
What it does:
Adds laninline Oid which points to function handling inline code (aka
anonymous code block).
Adds DO $$some code$$ [ LANGUAGE lanname ] syntax which sends the source
code to that laninline function of the specified language (or language
set by default_do_language guc).
There is implementation for plpgsql with simpler compiler which still
creates function struct for the executor (I believe there is no harm in
adjusting executor later, when current one works, just does unnecessary
stuff).
There is doc and a simple regression test for plpgsql implementation.
--
Regards
Petr Jelinek (PJMODOS)
Attachments:
[application/x-tar] inlinepl-2009-08-28.diff.gz (9.0K, ../../4A986AA6.7030505@pjmodos.net/2-inlinepl-2009-08-28.diff.gz)
download
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Anonymous code blocks (was: Re: GRANT ON ALL IN schema)
@ 2009-09-18 20:08 Brendan Jurd <direvus@gmail.com>
parent: Petr Jelinek <pjmodos@pjmodos.net>
0 siblings, 1 reply; 3+ messages in thread
From: Brendan Jurd @ 2009-09-18 20:08 UTC (permalink / raw)
To: Petr Jelinek <pjmodos@pjmodos.net>; Dimitri Fontaine <dfontaine@hi-media.com>; +Cc: pgsql-hackers
Hi Dimitri,
The commitfest app has you listed as the reviewer for this patch. Any
progress on your review?
Cheers,
BJ
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Anonymous code blocks (was: Re: GRANT ON ALL IN schema)
@ 2009-09-18 20:21 Dimitri Fontaine <dfontaine@hi-media.com>
parent: Brendan Jurd <direvus@gmail.com>
0 siblings, 0 replies; 3+ messages in thread
From: Dimitri Fontaine @ 2009-09-18 20:21 UTC (permalink / raw)
To: Brendan Jurd <direvus@gmail.com>; +Cc: Petr Jelinek <pjmodos@pjmodos.net>; pgsql-hackers
Brendan Jurd <direvus@gmail.com> writes:
> The commitfest app has you listed as the reviewer for this patch. Any
> progress on your review?
Funny I just sent a mail to rrr explaining I don't think I'll be able to
complete my review until next Thursday. Feel free to steal me the patch
if you want to, as I'm planning to start on Monday only...
Regards,
--
dim
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2009-09-18 20:21 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-08-28 23:39 Anonymous code blocks (was: Re: GRANT ON ALL IN schema) Petr Jelinek <pjmodos@pjmodos.net>
2009-09-18 20:08 ` Brendan Jurd <direvus@gmail.com>
2009-09-18 20:21 ` Dimitri Fontaine <dfontaine@hi-media.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox