Message-ID: <4AB62C62.5030109@cheapcomplexdevices.com>
Date: Sun, 20 Sep 2009 06:21:38 -0700
From: Ron Mayer <rm_pg@cheapcomplexdevices.com>
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
MIME-Version: 1.0
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
CC: Tom Lane <tgl@sss.pgh.pa.us>, "David E. Wheeler" <david@kineticode.com>,
	pgsql-hackers@postgresql.org
Subject: Re: updated hstore patch
References: <87zl8v36qo.fsf@news-spur.riddles.org.uk>
	<39EDBE64-BE43-4A3E-9514-D7EB2EAD6D35@kineticode.com>
	<14572.1253412218@sss.pgh.pa.us>
	<8763bejb5l.fsf@news-spur.riddles.org.uk>
In-Reply-To: <8763bejb5l.fsf@news-spur.riddles.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit

Andrew Gierth wrote:
> I'd appreciate public feedback on:
>  - whether conversions to/from a {key,val,key,val,...} array are needed
>    (and if there's strong opinions in favour of making them casts; in the
>    absence of strong support for that, I'll stick to functions)

Strikes me as an independent separate patch.  It seems totally
orthogonal to the features in the patch as submitted, no?

>  - what to do when installing the new version's .sql into an existing db;
>    the send/recv support and some of the index support doesn't get installed
>    if the hstore type and opclasses already exist. In the case of an upgrade
>    (or a dump/restore from an earlier version) it would be nice to make all
>    the functionality available; but there's no CREATE OR REPLACE for types
>    or operator classes.

It seems similar in ways to the PostGIS upgrade issues when their
types and operators change:
 http://postgis.refractions.net/docs/ch02.html#upgrading
It seems they've settled on a script which processes the dump file
to exclude the parts that would conflict?

If the perfect solution is too complex, I'd also kinda hope this isn't a
show-stopper for this patch, but rather a TODO for the future modules feature.


> If there are any more potential showstoppers I'd appreciate hearing about
> them now rather than later.