Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id B4ECA634102 for ; Sun, 11 Oct 2009 00:05:10 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 99711-02-7 for ; Sun, 11 Oct 2009 03:04:59 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from phoenix.advel.cz (phoenix.advel.cz [81.0.239.26]) by mail.postgresql.org (Postfix) with SMTP id ECBAE63453F for ; Sun, 11 Oct 2009 00:04:37 -0300 (ADT) Received: (qmail 25777 invoked from network); 11 Oct 2009 05:04:23 +0200 Received: from unknown (HELO ?10.12.0.96?) (88.103.48.48) by 192.168.1.50 with SMTP; 11 Oct 2009 05:04:23 +0200 Message-ID: <4AD14B31.5050309@pjmodos.net> Date: Sun, 11 Oct 2009 05:04:17 +0200 From: Petr Jelinek User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; cs; rv:1.8.1.23) Gecko/20090812 Lightning/0.9 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 MIME-Version: 1.0 To: Jaime Casanova CC: Robert Haas , Abhijit Menon-Sen , pgsql-hackers@postgresql.org Subject: Re: GRANT ON ALL IN schema References: <4A37BF63.50008@pjmodos.net> <4A6059B4.5010004@pjmodos.net> <4A607997.3030305@pjmodos.net> <21542.1249492707@sss.pgh.pa.us> <4A7F56A0.5060705@pjmodos.net> <4A7F5853.5010506@pjmodos.net> <20090920145011.GA24273@toroid.org> <4AB75A51.5060807@pjmodos.net> <603c8f070909270954n585e8e8am9eb1c187dec9fe19@mail.gmail.com> <3073cc9b0910100045qdcb2b3duabc05eb727ea0091@mail.gmail.com> In-Reply-To: <3073cc9b0910100045qdcb2b3duabc05eb727ea0091@mail.gmail.com> Content-Type: multipart/mixed; boundary="------------090705060200080808020102" X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.598 tagged_above=-10 required=5 tests=AWL=-0.000, BAYES_00=-2.599, HTML_MESSAGE=0.001 X-Spam-Level: X-Archive-Number: 200910/654 X-Sequence-Number: 147466 This is a multi-part message in MIME format. --------------090705060200080808020102 Content-Type: multipart/alternative; boundary="------------040705030306090309090901" --------------040705030306090309090901 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Jaime Casanova napsal(a): > On Sun, Sep 27, 2009 at 11:54 AM, Robert Haas wrote: > >> If this patch looks good now, can you mark it Ready for Committer in >> the CommitFest app? If there are any remaining issues, please post a >> further review. >> >> > > while i'm not the reviewer this patch doesn't apply cleanly anymore... > Fixed. > some comments: > 1) in docs for REVOKE you're omitting the SCHEMA part of the new syntax. > Fixed. > 2) i think that getNamespacesObjectsOids() could be rewritten in something like: > Right. -- Regards Petr Jelinek (PJMODOS) --------------040705030306090309090901 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit Jaime Casanova napsal(a):
On Sun, Sep 27, 2009 at 11:54 AM, Robert Haas <robertmhaas@gmail.com> wrote:
  
If this patch looks good now, can you mark it Ready for Committer in
the CommitFest app?  If there are any remaining issues, please post a
further review.

    

while i'm not the reviewer this patch doesn't apply cleanly anymore...
  

Fixed.

some comments:
1) in docs for REVOKE you're omitting the SCHEMA part of the new syntax.
  

Fixed.

2) i think that getNamespacesObjectsOids() could be rewritten in something like:
  

Right.

-- 
Regards
Petr Jelinek (PJMODOS)
--------------040705030306090309090901-- --------------090705060200080808020102 Content-Type: application/x-tar; name="grantonall-20091011.diff.gz" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="grantonall-20091011.diff.gz" H4sICEkV0UoAA2dyYW50b25hbGwtMjAwOTEwMTEuZGlmZgDtXPt32riz/5n+Ffr29N5C4hJe 5tF2e44LTsotAdaGdvvdu4djjEh8Y2zWhrbZtP/7nZEsW4B5pMk23d1veuqHHqOZz0ijGUl4 4kyn5NmzC2dBrJOJb5+EAfy/mLknAZ2eXASWt8jjKxnvyn3keBP6mVSsRqM8rubzlca43iip pFgoVCuVR0dHR7upP3r27NmeFo5W/0jfDxcXATV/7hCotpxRb2EtHN9jjZXKSqlBsNwjQl6G 154/D53wFbycGVp3QG7gn6l39OaAfCHtrqkb+DDst7SBDg8tyGIPA2PYbfI0Qz/VDb3b1E2W 3j470w3yFSji369KPp//DTK0Tof8SvpG+127o59B2d+gzL9YmV4Xcgba644OiS8DOnctm1pj lxLbtcLwp8d9zdDOoV3j8asFpo88a0ZfnkglX0FDBFuKmh30QI5fQabesL+faOCn0/xC+sPX nXaTfBXkgeb79uBNBFavP2gD89jooQBKYH0l2X2M2b67nHnpkpIc6xug0HIB+umzZz+UQm/u UaWcKG+R0TRBEGI23+jn2j7ioX1JZ9YO6rFg/4wus24sDuWAGY8y9LXYeKywPzS1MywZE4nq 3rLXmPrPQ5R0r1bp70vq2T+8IWgaOkew2et2OTAD/bzfMzTjQ/TMSO4CBwd5uaJUimKQ/xnA 39wr9PKAFXT/hmP2PrS7bTwKvW6rRCoNRVXFWHxoLPRf9OZwsJXfuJudwhzD6svcvZouPRsd lDR+skDt11Rh5lYAxRc0ePzKCi5m/mS96m8HVUxrNB29tXqL6/m27gmG9gcyQzu7EloXtaio dWFdHprbQ7vSzT+xM8mGVYj/tzOs+0xfir3czx+zmcVKWSlW6txqYs8vVqpKUW0kff/lCSrm FWcIXvnbMYPkkgaUOCGx3NAni0tK5n4YOmPHdRbXxJ8SFpI53gWZ02DmQJbvhWThQ3mX0M9O yPI4LX/8f9RehKyW85F6BPVPHC90JpT4HvwPyGzpLpw5yMO1FuaBA2hd9G+LNeuEnGC4nM/9 YEEnZApVmUcdKuSjQz/BTUzZwLo3iQnwN9vyIEqEFsfXZBkCh5weYn/Dfe0v8Qz+Je5yX6U+ J3UqAuHHwvoMghCmjkjYaSQvwTJ5lihwPuaAvBSoc5wjZEH2eeB8dFx6gbwH9LnQC3n50Qoc lNIFXF89muyM1QP60b+iW4N1KTuK1id2oV5QJ/m8NS7VpvXKnmhdJrAlXJeL3C5er2B4F03z hv6u91Zn41IaPqc9g4h55m8Svp8avfM/xwAJuUhTM5taiwNggtiAGLNDLKYG0GN3+4cF/UFC 7FvMIQ+oxPUhtkuHLLCtK5XK7UbZDxvxPvDYKTeUSvV2Y+cvH8P+PQdFtaRU69JqzyHK/E8g uCcQfODRWa0oNXkh6T51+p+IbE9E9tcwEyu+NDqxY8u+ot7kxLYWlutfnFi2a19e5W3wc3dl R750SbXq06qVz49LjXHZmq760jsJcF96Z5F1mxai62yTj74zISZdtOjUgjBKa3bCtmfyOCrb 9haUh4PFglIsqlI4yBJqYnxsJcZIBBCCJUnkyAGmwtwLPq6iqh2ITsgRj366oJ1w4PecSZg9 w1Cxx5IHGPlBCexvSlIBdYnUjldJXVBOZw4aDjmB8BCKXjjfTtGgLgs4AKOYeBaosniNvbUn CrEvrYAE1L0CvTIxZXjo5zlEkyPbd0dJyJblLUAiI6QQpMldUaijAIkM/kG0abvnMMAhqHZC qX5KiaPVFpSNDqB/pvZyQRkc5mK2yMZP5CiEa477e2VVKVeKYnLLkKMTvDlYIg88sFCe/ETw /dkrkfAiKRPBGxeJ3l+APUhKsBD/J7Kp/pU6SkICKzBoMydHuGzAJGVrCGNKpo7rQnw/pq7/ KeIXSkkB8tZinCGBHLLUbXdeZLD6zLom0AM2ajFPrlxTyqoqRsO9goQ4hZ+chX1JIjRYZczO Yd4NXjK2FVI+M40GH/r6qPf6f56zjLtjzKiMA2pdvUhtCuz5qN0dcSu+pdGtg/GWbU+4FYla ARVcZHXD6BkKebz0Amr7F57zB2iHA440n5P/mjwWhBPkGDmckX+ELrQ+Mg+1gtz3VKtKtVpM THO1VlBq9XLcGQO6WAaeWEjDTodTJ19POjnCRaWjrfphubzIGTCO63PSgpwlL8lNA39Gwjm1 nakDwvEJnOCiE3E8XNvzmFHDBLawBXKv2Vd4v7PRBho38D+DyWAMxYwi1CCymhQkgVwb7i84 FJmpD/3MvsximkJkihlGMoNmndGM8hi1DLAHXVGy/zw5ZiAQUwZPN23Le0uvWzA9kyt6/Wvx N57+hlpzzGvR0AbwLC9JHiznLs0s8MoTxSwEqo25z0RMMRMSvLPcrDt1gnDBxMnleEWJSyjX 8f2r5Vz/PHcd20lwz0aUcjFpYX4i0BkkESbcGsCsjhYHQtKRoXc09Oye8+xMLD63AqkT6Mrk CQTetrutmFDEeiaTaBL7EEygHvg42ShVIXFDCd93aP1dW3//bS1nEouVCpCIkO8MkCD057Ap PHTBZtRv256zyP43dtzCb0qUBX+at5yN5hdg8nwbLzHDUpnXA/33peWai8Ba0Ivr7nI2poFC Tke9dkv/WSrIh3l7AhYHhslyJoufW9MuCHsJQ2Tkz6mX7UPrdLIMqAAR4dJsMCWhCWOXdnz7 Sq6Pw0wQGNMLx8OELFBViOlZ8/DSX3T9TwopKjhU5ZqfLmEaINksG5SCBGjPo58XWaQCcvnB JyuYsDHtwNSE/ORy5F9giIadTi4idCPElpRnzUGYCTp+ifJiOwCggMXhDediTX5NWGOsQH0m C15kvlmm7foh5WKmgbPeM+I5l2fBPAbALF3wef0FuWTMcmOe2Tklx96lcHb4zCzkJ1mYJXLC rkeMoFixbOvz2DH5yiuvzmNpA0iaxgxOhc1LMIUlo8/xotks7m04T0PwgjP1dVyQoFO/a/76 hhBhY9KSbYKYttYnjhKfONLnjbRpI23W2DGqxZBmEfQI6myM6cMG9GGjeYOR4nZGELO9PDTf aEbCRBPgjhkQsMeNr9sRgdQhZuRQG1JatSH3Y0C49ZB7i2w84vTd5kOMr+2G4xCrIY3QFY8n og4e5wk7fnNEtM5AN0hLP9WGnYG8RIaDieKeHit3sn15xYP4Njyx/fk1LpiFG+srG/nRAotd VWmhYOXzql1olIrq9gWWTQqbKyybZdb9+BFmpsbX6Czz+LpULtWVUrlcThx4kVSRVh8zzV7/ A8RYWkczRqdtvdPKijCSh8Gb+SumdDNbjoVE/W6vpSe1kxh7PTOJg9LzGW3KcvcokeLo3aVF uYBYJyvUJo1aLZ+3x7RanFT3qXGFxDY9rhTaUCTLTdWkpSQzG9s4II1GUWk0qok+eUK8VnbD ETvvg4HardGUImtKTSmxoVdeZrtqN/I3tbtR5BAFz60gpAEev5/lr9cwX8mL1FqYFop2sZTP T6t1q1htbFfrau1Nja7mrymT66iqFAslsaiFaIGXg4HT0l6QPsg/sAKwxkJbW6JPtoggR5o8 upYIRGucvBtgm3FYfqc2WR6mZjKxuleYIfsY2rIajDTRayFHA1x8PIXxIJL4EiVDr1IvKpV6 LV4T1H9pdoatdveMsCez/U6Pt0L0X9rmwIRbv6O1u3AH49/VOvhgaM1BZN1OtY6pj/rkVDtv dz6QU33QfENO24Y5wMROT2P3XqfTe4/N4K4L/G/qeNXbZ2wf5r1mtBCDU0PX/63zfYHTobTZ ELV11um9Bgb4Ng676i244wFVc8B3EUZ9obRKvQSixkf+/iqiJhsstxX6Th1DLTYUtZwsFvMY /h2KC4+6Zupw72rneOtD2+xIBjx2tCa/t5sa7rHoA7bTohkDTiXadDH0wdDoIir8yRSbckb7 7A1k95AaIPdaa76Fh/f4H8oMOzpKBniZ2ju932sDBNGek9nE8sTUNQO0YOrNHgTWfXwYGu3B B7HPLkJt5MbUjbbWaf+b8Q4v78CZMXXTbLMjCuw+GposESsOeqfERF+U1X0DTJltULxm4L2P JM61Toex1ANcTI4J3LotrdPrInQMCLwO9HO9yyDBF+hs7aYJ6S3cQxu0ekMs1DPwhAAHjNU1 2n28D1/jI0BnDvu6gQwyfWfMD+fnOpYm5gez3cIrNMP7AiDG2eHnXPqoJXZUGy8dPHeQHOIe QC+HdgZv9C4ZtEESvACb56yVQY/AGGh3kAF46Joa76YD7IHxqR64n+PRH52zFh8CggcT+ytb bo6HploqQGcrxUPz79bZkrMU/+xu9+P1vnUbGTuAzzPcwEr7BNBM/MYnz3IJppRyqZY4iPBW xqT4dC1bEfGSnSII7MBNoC+kLKmJn8iTkpyVbCZln1Ry0mbScVwk9hriQpIfsUIpWpSKKYVy vnADkYXqRgYE02zFBDJrLzZAM9g5T4ZahAseLStXyjIulQImVddxWSM/tdzwLwTOmF5aHx0/ OBgYFdytslqVgVErkFQt7AFmd6dRt+FSOwSX2iG41Pbg0tiGS7GwCUzM/WjBfNkIHug4Clyk s+rwVoOkSlmG50a0lDjD5AhBysoJOTK3XNe3s6HzB/WnUl4ulw5Xyt7HNtBW92fXyDE8inHi kyfw7onXzdP828DAEVOpqDIYFRWS1OJfDozS3cHAbqCWZDBU7Cxq4zuDIabyhwQDTQZKLoFR BcNSqda+MxinrfffjkPlzjhwoasrODQgqaZ+bxx4QDfi3ty3Q1K+OyR4qLsmz7yVGg6d+ve2 oCJsfchxUkNzWS/IYNQxqfG9LWgLYxYIYx4SDFz+iJd6OBgNtKCN721BO1r3bAgxxoOCgWai UZHAUAtgTNTC97agGNWygOgh0WhUuegMje8mehIM3k4qvLPFz2e4Hhb5oCPcBn7Oy0RJGfF3 QxgJdpRiZl3RYvZJMfeCcEqZLyskyFPlKZEIiLp8Mw4qKmClWeWo10BHUiuV79xrZOjuv9sc c1hWfhaFKwB87QM3fRlU6+ce7iDu8W5xb+GArhxhXCMsQqXjVbGPN8WWf/vyoJLfwtu8H8nl 4/wPKvkt/Ic7SB7bkgc0JOtWGs/ahDT4SCejK3r9yQ8m3E4XC2q5ouBV8vzhtVbExJo8c33h Gw3SC9tnEK9iF+V49d0UBfgWQ/zG9xjE6xut2+roxi3YruIv0OEq/wa9UK0j29X6KttiKVV6 ZyuqyXu0fH+8+m4mBZLFVSkNvPLkjS2x3ob/KuO/usJ/rVBS8Fpf5X91bZQl4aqo9MIXRyP+ uX0VuYlZj1P08778jIulm/u0jme7ywmN9r/Znil7zF9G26nbC4gff6uqVaxN8/lyY1qY0tLm ju0OEsm27Y5C63CLXVPqLWdkbYeU415sAMKlQkn+qQpPSjzW1DmRnWzjnwNgh7/Yae6v642w YX+cwgfjIDrHtTqNKkT+O2Fbat7ECsQpdV8cPOMLZ9kwFx2n22asIjJx7bVT2dEHEiKi/Bx2 TPRrwu0LfixnbSM6Xst+FO1Dd0EVA+sik4nX+ca+7+IR/+hXDBy4YBnbV4UvyMJrtGPCD8Zv 29DG6ngeS/r6wZjiByD8OcVTXROUMUIk3vdOVh5584zglH1rguNi+7MZwIyfdKAsmanKGvsf I9VuHBHnlMTBQMPyLug7KyCsKyoEdzzfO4tLLbgIozThCcEfOcLvUMxdy4nOD5KsFZJ3lguo ALAgDVeA3GyyGLvaMj9dhdMebyf1KJQYM9FRh6tP7Fz9+shdyxXHoOrTWq1az+crpWmZFlKO QW2rvzlm10usD9j+2eit/uF9z2hlH08DSv+gjwFLtm2t8B0VnEdGXT540WSuGEyWEA/cVWL+ jJHqnStsFw+sdUtk59YLL10XCw87nZVWIYzaXoX/FJNV4zOdQobdzZaOU6uFUj0zveJqexeu P7aQST6NHlQFOzrW4IPuoOJ0IirorfQ2dmkwpLbvIQUx40okmAbx5NrKWbZyqQEJapoGgdgy cBbXnBybsA+ROqQujFZWCbdL98stfsLOqvCJ/xBNxp+CkeodpEkYD47lOn/gVMLqJr7FgdU/ 0oBXBAfksCrsEzqsDnNTvkGz17MZBUNlIxGxNxthyzWrVpWy/DOjsgqqrlZSNXsdOqyXoBNz kADX4YLOeA3m6RxSaREBPODI7tMnn9pF+YM0mXgDcTX0FA6qSmdzrATe16HFXZjroirosKVX 25gIFjRcnAT0AtzQ8IR+nsPYoJOTZG7J+8tFZLMPKSqOWFZK5Uapls9Tq1CsWCme3UHEkvni oOLrHTQ6EHFphSP+W9i4fPZpRGsJw6XI2KoXVaVekpZtWUIl+WIVejTZIgn8TznuxEGZsy0+ 1MqnpogVeVFQh58XEQcvtOHgTc+AsS1izsjhwZgYs9M+ETNfjl3H5me2ZCGw+qECP1XIUwsh ZU+81lMIC0Ei5nrh7xNSiDCZU/6w+BQuAh12YntTlLQf7e+WZgtS2+RGiXACLWVVIYzjQjb7 PclzIn0tjEyo50Sf8BJTblJ9v574MY0D1DTo3V1JpQ0lobf8DTparOtoQ4wdKkqV5K4K8q8Y XxLwayxHf0V1lXWClVH6+PsyMQCMWggl/tcmOG6jT4fGp6I+Y52UY8crFib83ZWNC7ym2aHN UpH5o5ZVrzVoPl+vFWrjccqXGPbR2WL5Ukp+o9ErM2bYzmVN3pGABLUQ71Tduq9Wkr66+flB uffyY8TfZkT3j8+7m9L7tab3Yg9vNeL2W8WDULyLobtXW3d3a3Vf8DGbdUsj9Oj/AQKtomXj YAAA --------------090705060200080808020102--