Message-ID: <4AD3D516.9090704@ak.jp.nec.com>
Date: Tue, 13 Oct 2009 10:17:10 +0900
From: KaiGai Kohei <kaigai@ak.jp.nec.com>
User-Agent: Thunderbird 2.0.0.6 (Windows/20070728)
MIME-Version: 1.0
To: Stephen Frost <sfrost@snowman.net>
CC: robertmhaas@gmail.com, pgsql-hackers@postgresql.org, kaigai@kaigai.gr.jp
Subject: Re: [PATCH] Reworks for Access Control facilities (r2350)
References: <4AC5A14F.6050306@ak.jp.nec.com>
	<20091012024604.GW17756@tamriel.snowman.net>
In-Reply-To: <20091012024604.GW17756@tamriel.snowman.net>
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit

Stephen, Thanks for your reviewing comments, although you have busy days.

Stephen Frost wrote:
> KaiGai,
> 
> * KaiGai Kohei (kaigai@ak.jp.nec.com) wrote:
>> Please review the new revision, Thanks,
> 
> In general, I'm pretty happy with this revision.  You still have a
> number of places where you have comments about code which does not exist
> any more.  For example, the comments about the check being removed from
> LookupCreationNamespace.  I would recommend pulling out those comments
> and instead having a comment at the top of the function that says
> "namespace creation permission checks are handled in the individual
> object ac_*_create() routines". 
> 
> I don't like having comments that are about code which was removed.
> Some of these could be moved to the README if they aren't there already
> and they really need to be kept.

OK, I'll check and revise these commenting issues soon.

Please wait for a couple of days at most.

> There are some other grammatical and spelling issues in the comments,
> but I don't believe any of this should hold this patch up from being
> ready for committer.  At a minimum, I think this really needs to have a
> committer comment on it to ensure we're going in the right direction.
> I'd be happy to continue working with KaiGai to review his changes going
> forward, either with the next set of SE-PG patches or reworking this one
> if necessary.
> 
> 	Thanks,
> 
> 		Stephen


-- 
OSS Platform Development Division, NEC
KaiGai Kohei <kaigai@ak.jp.nec.com>