Message-ID: <4BD73DB0.6090307@enterprisedb.com>
Date: Tue, 27 Apr 2010 22:40:32 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090706)
MIME-Version: 1.0
To: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
CC: pgsql-hackers@postgresql.org
Subject: Re: CP949 for EUC-KR?
References: <20100427192740.9B68.52131E4D@oss.ntt.co.jp>
	<4BD6C522.80200@enterprisedb.com>
	<20100427202337.9B70.52131E4D@oss.ntt.co.jp>
In-Reply-To: <20100427202337.9B70.52131E4D@oss.ntt.co.jp>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Takahiro Itagaki wrote:
> That's it! We should have added an additional alias to chklocale, too.
> 
> Index: src/port/chklocale.c
> ===================================================================
> --- src/port/chklocale.c	(HEAD)
> +++ src/port/chklocale.c	(fixed)
> @@ -172,6 +172,7 @@
>  	{PG_GBK, "CP936"},
>  
>  	{PG_UHC, "UHC"},
> +	{PG_UHC, "CP949"},
>  
>  	{PG_JOHAB, "JOHAB"},
>  	{PG_JOHAB, "CP1361"},

Yeah, seems correct.

> Except UHC, we don't have any codepage aliases for the encodings below.
> I assume we don't need to add CPxxx because Windows does not have
> corresponding codepages for them, right?
> 
>     {PG_LATIN6, "ISO-8859-10"},
>     {PG_LATIN7, "ISO-8859-13"},
>     {PG_LATIN8, "ISO-8859-14"},
>     {PG_LATIN10, "ISO-8859-16"},
>     {PG_SHIFT_JIS_2004, "SJIS_2004"},

Yeah, I guess so. I can't find Windows codepages for these either, by
google.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com