Message-ID: <4BE8AEE0.7080701@2ndquadrant.com>
Date: Mon, 10 May 2010 21:12:00 -0400
From: Greg Smith <greg@2ndquadrant.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20100317)
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: bricklen <bricklen@gmail.com>, pgsql-general@postgresql.org
Subject: Re: Archiver not picking up changes to archive_command
References: <AANLkTinmg9-gtu9NUxebe-NKfk5dkhNY2-sa1H0-WxCr@mail.gmail.com>
	<21571.1273539053@sss.pgh.pa.us>
In-Reply-To: <21571.1273539053@sss.pgh.pa.us>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Tom Lane wrote:
> A look at the code shows that the archiver only notices SIGHUP once
> per outer loop, so the change would only take effect once you catch up,
> which is not going to help much in this case.  Possibly we should change
> it to check for SIGHUP after each archive_command execution.
>   

I never considered this a really important issue to sort out because I 
tell everybody it's unwise to put something complicated directly into 
archive_command.  Much better to call a script that gets passed %f/%p, 
then let that script do all the work; don't even have to touch the 
server config if you need to fix something then.  The lack of error 
checking that you get when just writing some shell commands directly in 
the archive_command itself horrifies me in a production environment.

-- 
Greg Smith  2ndQuadrant US  Baltimore, MD
PostgreSQL Training, Services and Support
greg@2ndQuadrant.com   www.2ndQuadrant.us