Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id B69AA1337B2F for ; Fri, 3 Dec 2010 05:23:04 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 73483-04 for ; Fri, 3 Dec 2010 09:22:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from exprod7og110.obsmtp.com (exprod7og110.obsmtp.com [64.18.2.173]) by mail.postgresql.org (Postfix) with SMTP id D00C3133798E for ; Fri, 3 Dec 2010 05:22:56 -0400 (AST) Received: from source ([209.85.215.181]) by exprod7ob110.postini.com ([64.18.6.12]) with SMTP ID DSNKTPi28NILugUHVgWpvUqz6X+NDg1FCkn4@postini.com; Fri, 03 Dec 2010 01:22:57 PST Received: by eyb6 with SMTP id 6so5562621eyb.26 for ; Fri, 03 Dec 2010 01:22:55 -0800 (PST) Received: by 10.213.31.132 with SMTP id y4mr2156903ebc.55.1291368175549; Fri, 03 Dec 2010 01:22:55 -0800 (PST) Received: from [192.168.1.183] (dsl-hkibrasgw2-ff7ac300-240.dhcp.inet.fi [88.195.122.240]) by mx.google.com with ESMTPS id b52sm1300807eei.19.2010.12.03.01.22.54 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 03 Dec 2010 01:22:55 -0800 (PST) Message-ID: <4CF8B6ED.3090300@enterprisedb.com> Date: Fri, 03 Dec 2010 11:22:53 +0200 From: Heikki Linnakangas User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI; rv:1.9.1.15) Gecko/20101030 Icedove/3.0.10 MIME-Version: 1.0 To: Alvaro Herrera CC: Joachim Wieland , Tom Lane , =?UTF-8?B?Sm9zw6kgQXJ0aHVyIEJlbmV0YXNzbyBWaWxsYW5vdmE=?= , pgsql-hackers Subject: Re: directory archive format for pg_dump References: <4CEA9F29.5060106@enterprisedb.com> <28890.1290445623@sss.pgh.pa.us> <4CEAD61A.6060207@enterprisedb.com> <4CF40B5F.1010407@enterprisedb.com> <4CF655A3.4090308@enterprisedb.com> <4CF6562E.60506@enterprisedb.com> <4CF74F99.4050008@enterprisedb.com> <4CF7F8FB.1040305@enterprisedb.com> <1291324036-sup-7776@alvh.no-ip.org> In-Reply-To: <1291324036-sup-7776@alvh.no-ip.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-4.2 tagged_above=-5 required=5 tests=BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3 X-Spam-Level: X-Archive-Number: 201012/238 X-Sequence-Number: 175500 On 02.12.2010 23:12, Alvaro Herrera wrote: > Excerpts from Heikki Linnakangas's message of jue dic 02 16:52:27 -0300 2010: >> Ok, committed, with some small cleanup since the last patch I posted. > > I think the comments on _ReadBuf and friends need to be updated, since > they are not just for headers and TOC stuff anymore. I'm not sure if > they were already outdated before your patch ... "These routines are only used to read & write headers & TOC" Hmm, ReadInt calls _ReadByte, and PrintData used to call ReadInt, so it was indirectly been called for things other than headers and TOC already. Unless you consider the "headers" to include length integer in in each data block. I'm inclined to just remove that sentence. I also note that the _Clone and _DeClone functions are a bit misplaced. There's a big "END OF FORMAT CALLBACKS" earlier in the file, but _Clone and _DeClone are such callbacks. I'll move them to the right place. PS. Thanks for the cleanup you did yesterday. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com