Message-ID: <4D0A2EFF.9020104@enterprisedb.com>
Date: Thu, 16 Dec 2010 17:23:43 +0200
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI;
	rv:1.9.1.15) Gecko/20101030 Icedove/3.0.10
MIME-Version: 1.0
To: Joachim Wieland <joe@mcknight.de>
CC: Greg Smith <greg@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	=?ISO-8859-1?Q?Jos=E9_Arthur_Benetasso_Villanova?=
	<jose.arthur@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: directory archive format for pg_dump
References: <AANLkTi=AEi3F6jC0Zy3dG9njiwJJC8Y6V090-hMonyyn@mail.gmail.com>
	<AANLkTik+PR2HCsqS7PVAdETPyKSGn2hb-eTeg9QZpRew@mail.gmail.com>
	<4CEA9F29.5060106@enterprisedb.com>	<28890.1290445623@sss.pgh.pa.us>
	<4CEAD61A.6060207@enterprisedb.com>
	<AANLkTi=neaBqvLa2ZnDpuAMSen3P4ZHE8__Q7L2pmjD0@mail.gmail.com>
	<4CF40B5F.1010407@enterprisedb.com>	<4CF655A3.4090308@enterprisedb.com>
	<4CF6562E.60506@enterprisedb.com>
	<AANLkTinauQsCGt-yeyeN_QWuN+tao+q126rwKnO2QWLP@mail.gmail.com>
	<4CF74F99.4050008@enterprisedb.com>	<4CF7F8FB.1040305@enterprisedb.com>
	<AANLkTik=3XBZq-PbC9CNTV1X6+-+Yd9gOdwf7rYjCpBp@mail.gmail.com>
	<4D09E624.4030706@2ndquadrant.com>
In-Reply-To: <4D09E624.4030706@2ndquadrant.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 16.12.2010 12:12, Greg Smith wrote:
> Moving onto the directory archive part of this patch, the feature seems
> to work as advertised; here's a quick test case:
>
> createdb pgbench
> pgbench -i -s 1 pgbench
> pg_dump -F d -f test
> pg_restore -k test
> pg_restore -l test
> createdb copy
> pg_restore -d copy test
>
> The copy made that way looked good. There's a good chunk of code in the
> patch that revolves around BLOB support. We need to get someone who is
> more familiar with those than me to suggest some tests for that part
> before this gets committed. If you could suggest how to test that code,
> that would be helpful.
>
> There's a number of small things that I'd like to see improved in new
> rev of this code
> ...

In addition to those:

The "check" functionality seems orthogonal, it should be splitted off to 
a separate patch. It would possibly be useful to be perform sanity 
checks on an archive in custom format too, and the directory format 
works just as well without it.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com