Message-ID: <4D357E9C.6080206@2ndquadrant.com>
Date: Tue, 18 Jan 2011 06:50:52 -0500
From: Greg Smith <greg@2ndquadrant.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20100317)
MIME-Version: 1.0
To: Fujii Masao <masao.fujii@gmail.com>
CC: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	Magnus Hagander <magnus@hagander.net>, pgsql-hackers@postgresql.org
Subject: Re: auto-sizing wal_buffers
References: <AANLkTik3mZ3sTfbHQW-1B44NRMkUzRsMnPb8g-HtttVv@mail.gmail.com>
	<AANLkTimQ3+osgAEH4meS97FmLN-4evSTS2W6fctov=jY@mail.gmail.com>
	<AANLkTinhU9EEPGM29S+KH=qK4t-mLhBBNAaLCGQSx-4y@mail.gmail.com>
	<20767.1294964709@sss.pgh.pa.us>	<4D314406.3000703@2ndquadrant.com>
	<AANLkTikoUWemGmAmNGHXW8QQoo45sLxzr-aU=rUwshba@mail.gmail.com>
	<4D31D0E4.9000108@2ndquadrant.com>
	<AANLkTi=hsuB-5aBBFwwA-mhDgezM91tt+uXPofY7Gjyc@mail.gmail.com>
In-Reply-To: <AANLkTi=hsuB-5aBBFwwA-mhDgezM91tt+uXPofY7Gjyc@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Fujii Masao wrote:
> +/* Minimum setting used for a lower bound on wal_buffers */
> +#define XLOG_BUFFER_MIN			4
>
> Why didn't you use XLOG_BUFFER_MIN instead of XLOGbuffersMin?
> XLOG_BUFFER_MIN is not used anywhere for now.
>   

That's a typo; will fix.

> +		if (XLOGbuffers < (XLOGbuffersMin * 2))
> +			XLOGbuffers = XLOGbuffersMin * 2;
> +		}
>
> Why is the minimum value 64kB only when wal_buffers is set to
> -1? This seems confusing for users.
>   

That's because the current default on older versions is 64kB.  Since the 
automatic selection is going to be the new default, I hope, I don't want 
it to be possible it will pick a number smaller than the default of 
older versions.  So the automatic lower limit is 64kB, while the actual 
manually set lower limit remains 32kB, as before.

-- 
Greg Smith   2ndQuadrant US    greg@2ndQuadrant.com   Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support  www.2ndQuadrant.us
"PostgreSQL 9.0 High Performance": http://www.2ndQuadrant.com/books