Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id 68EF01337B68 for ; Wed, 16 Feb 2011 13:35:51 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 31300-06 for ; Wed, 16 Feb 2011 17:35:44 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from exprod7og126.obsmtp.com (exprod7og126.obsmtp.com [64.18.2.206]) by mail.postgresql.org (Postfix) with ESMTP id 64CA5133616B for ; Wed, 16 Feb 2011 13:35:43 -0400 (AST) Received: from source ([209.85.215.170]) (using TLSv1) by exprod7ob126.postini.com ([64.18.6.12]) with SMTP ID DSNKTVwK7hdh2WOc6p3MzftKHVznf3KTq3jj@postini.com; Wed, 16 Feb 2011 09:35:43 PST Received: by eyf5 with SMTP id 5so1152078eyf.15 for ; Wed, 16 Feb 2011 09:35:41 -0800 (PST) Received: by 10.216.178.132 with SMTP id f4mr726594wem.62.1297877702840; Wed, 16 Feb 2011 09:35:02 -0800 (PST) Received: from [192.168.1.183] (dsl-hkibrasgw2-ff7ac300-240.dhcp.inet.fi [88.195.122.240]) by mx.google.com with ESMTPS id n1sm184072weq.7.2011.02.16.09.35.00 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 16 Feb 2011 09:35:01 -0800 (PST) Message-ID: <4D5C0AC3.1010101@enterprisedb.com> Date: Wed, 16 Feb 2011 19:34:59 +0200 From: Heikki Linnakangas User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI; rv:1.9.1.16) Gecko/20101226 Icedove/3.0.11 MIME-Version: 1.0 To: Robert Haas CC: Simon Riggs , Fujii Masao , pgsql-hackers@postgresql.org Subject: Re: Sync Rep for 2011CF1 References: <1295127631.3282.100.camel@ebony> <4D543723.9050101@enterprisedb.com> <1297870600.1747.30144.camel@ebony> <4D5BEFF9.6020906@enterprisedb.com> <1297873941.1747.30561.camel@ebony> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-4.2 tagged_above=-5 required=5 tests=BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3 X-Spam-Level: X-Archive-Number: 201102/1546 X-Sequence-Number: 182335 On 16.02.2011 19:29, Robert Haas wrote: > Actually, on further reflection, I'm not even sure why we bother with > the fsync. It seems like a useful safeguard but I'm not seeing how we > can get to that point without having fsync'd everything anyway. Am I > missing something? WalRcvDie() is called on error. For example, if the connection dies unexpectedly during walrcv_receive(). -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com