Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id E1CFB1337B61 for ; Sat, 23 Apr 2011 20:03:42 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 82993-02 for ; Sat, 23 Apr 2011 23:03:25 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from cdptpa-omtalb.mail.rr.com (cdptpa-omtalb.mail.rr.com [75.180.132.121]) by mail.postgresql.org (Postfix) with ESMTP id E3BF5133616B for ; Sat, 23 Apr 2011 20:03:23 -0300 (ADT) X-Authority-Analysis: v=1.1 cv=r4yJ8ACLDmU9N8MfnU6qGSvboKzSN9UnPAeXToqJDNE= c=1 sm=0 a=lpDWfFNTT9MA:10 a=Acs96HtBqXsA:10 a=8nJEP1OIZ-IA:10 a=qCTYjJJ2g1SgQhsHZAUATw==:17 a=Uv--w3h2eK5qGVf216UA:9 a=wPNLvfGTeEIA:10 a=qCTYjJJ2g1SgQhsHZAUATw==:117 X-Cloudmark-Score: 0 X-Originating-IP: 98.27.48.207 Received: from [98.27.48.207] ([98.27.48.207:34788] helo=[192.168.10.146]) by cdptpa-oedge01.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id F6/AD-09483-BBA53BD4; Sat, 23 Apr 2011 23:03:23 +0000 Message-ID: <4DB35ABB.9010904@dunslane.net> Date: Sat, 23 Apr 2011 19:03:23 -0400 From: Andrew Dunstan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.9 MIME-Version: 1.0 To: PostgreSQL-development Subject: code cleanups Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.9 tagged_above=-5 required=5 tests=BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001 X-Spam-Level: X-Archive-Number: 201104/1301 X-Sequence-Number: 186503 getopt.c is looking a bit ancient. In particular, getopt() has no prototype and old style arguments. Is there any reason not to bring this into the 1990s (or is that 1980s?) gcc also doesn't like the way perl does unused attributes on Windows, and it generates quite a few warnings about it. A little experimentation suggests this would probably clean it up if placed at the start of plperl.h: #if defined(__GNUC_) #define PERL_UNUSED_DECL __attribute__ ((unused)) #endif Thoughts? cheers andrew