Message-ID: <4E0B7A68.5030102@enterprisedb.com>
Date: Wed, 29 Jun 2011 22:18:00 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI;
	rv:1.9.2.17) Gecko/20110606 Icedove/3.1.10
MIME-Version: 1.0
To: Kevin Grittner <Kevin.Grittner@wicourts.gov>
CC: drkp@csail.mit.edu, pgsql-hackers@postgresql.org
Subject: Re: SSI modularity questions
References: <4E0A0240020000250003ECDA@gw.wicourts.gov>
In-Reply-To: <4E0A0240020000250003ECDA@gw.wicourts.gov>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 29.06.2011 00:33, Kevin Grittner wrote:
> Heikki Linnakangas  wrote:
>> On 28.06.2011 20:47, Kevin Grittner wrote:
>
>> Hmm, the calls in question are the ones in heapgettup() and
>> heapgettup_pagemode(), which are subroutines of heap_getnext().
>> heap_getnext() is only used in sequential scans, so it seems safe
>> to remove those calls.
>
> I haven't found anything to the contrary, if I understand correctly,
> Dan found the same, and all the tests pass without them.  Here's a
> patch to remove them.  This makes the recently-added
> rs_relpredicatelocked boolean field unnecessary, so that's removed in
> this patch, too.

Thanks, committed. I also moved the PredicateLockRelation() call to 
heap_beginscan(), per earlier discussion.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com