Message-ID: <4E0B7AAF.10903@enterprisedb.com>
Date: Wed, 29 Jun 2011 22:19:11 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI;
	rv:1.9.2.17) Gecko/20110606 Icedove/3.1.10
MIME-Version: 1.0
To: Kevin Grittner <Kevin.Grittner@wicourts.gov>
CC: drkp@csail.mit.edu, pgsql-hackers@postgresql.org
Subject: Re: Repeated PredicateLockRelation calls during seqscan
References: <4E07550F020000250003EC42@gw.wicourts.gov>
In-Reply-To: <4E07550F020000250003EC42@gw.wicourts.gov>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 26.06.2011 23:49, Kevin Grittner wrote:
> "Kevin Grittner"  wrote:
>> "Kevin Grittner" wrote:
>>> Heikki Linnakangas wrote:
>
>>>> BTW, isn't bitgetpage() in nodeBitmapHeapscan.c missing
>>>> PredicateLockTuple() and CheckForSerializableConflictOut() calls
>>>> in the codepath for a lossy bitmap? In the non-lossy case,
>>>> heap_hot_search_buffer() takes care of it, but not in the lossy
>>>> case.
>>>
>>> I think the attached addresses that.
>>
>> Don't commit that patch, it's not holding up in testing here.
>>
>> I'll look at it some more.
>
> Version 2 is attached.

Thanks, applied this too.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com