Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id 0E65CB5DBBF for ; Wed, 27 Jul 2011 11:06:04 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 18516-04 for ; Wed, 27 Jul 2011 14:05:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from exprod7og117.obsmtp.com (exprod7og117.obsmtp.com [64.18.2.6]) by mail.postgresql.org (Postfix) with ESMTP id 2186DB5D91F for ; Wed, 27 Jul 2011 11:05:56 -0300 (ADT) Received: from mail-fx0-f42.google.com ([209.85.161.42]) (using TLSv1) by exprod7ob117.postini.com ([64.18.6.12]) with SMTP ID DSNKTjAbRNbdkKvLvihETKWgCzBNoEHpiNKL@postini.com; Wed, 27 Jul 2011 07:05:58 PDT Received: by fxe23 with SMTP id 23so442573fxe.15 for ; Wed, 27 Jul 2011 07:05:54 -0700 (PDT) Received: by 10.223.88.219 with SMTP id b27mr123699fam.21.1311775553900; Wed, 27 Jul 2011 07:05:53 -0700 (PDT) Received: from [192.168.1.183] (dsl-hkibrasgw2-ff7ac300-240.dhcp.inet.fi [88.195.122.240]) by mx.google.com with ESMTPS id p17sm83005fak.25.2011.07.27.07.05.51 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Jul 2011 07:05:52 -0700 (PDT) Message-ID: <4E301B3E.5080707@enterprisedb.com> Date: Wed, 27 Jul 2011 17:05:50 +0300 From: Heikki Linnakangas User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI; rv:1.9.2.18) Gecko/20110626 Icedove/3.1.11 MIME-Version: 1.0 To: Alexander Korotkov CC: pgsql-hackers Subject: Re: WIP: Fast GiST index build References: <26338.1310134685@sss.pgh.pa.us> <4E1DA4CB.9020209@enterprisedb.com> <4E1EABD9.5000308@enterprisedb.com> <4E1F5763.9090109@enterprisedb.com> <4E2DBB60.80604@enterprisedb.com> <4E2EF83A.8000304@enterprisedb.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.9 tagged_above=-5 required=5 tests=BAYES_00=-1.9 X-Spam-Level: X-Archive-Number: 201107/1459 X-Sequence-Number: 192558 On 27.07.2011 15:29, Alexander Korotkov wrote: > I found a problem in WAL with this patch. I use simplified insert algorithm > in my patch which don't insert downlink one by one but insert them at once. > Thus FollowRight flag is leaving uncleared when redoing from WAL, because > only one flag can be cleared by one WAL record. Do you think modification of > WAL record structure is possible or I have to insert downlink one by one in > buffering build too? Dunno, both approaches seem reasonable to me. There's no rule against changing WAL record structure across major releases, if that's what you were worried about. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com