Received: from maia.hub.org (maia-2.hub.org [200.46.204.251])
	by mail.postgresql.org (Postfix) with ESMTP id F19F4B5DBC1
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Thu, 28 Jul 2011 18:10:40 -0300 (ADT)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia,
	port 10024) with ESMTP id 04997-01
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Thu, 28 Jul 2011 21:10:34 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from exprod7og118.obsmtp.com (exprod7og118.obsmtp.com [64.18.2.8])
	by mail.postgresql.org (Postfix) with ESMTP id A272FB5D800
	for <pgsql-hackers@postgresql.org>;
	Thu, 28 Jul 2011 18:10:33 -0300 (ADT)
Received: from mail-fx0-f46.google.com ([209.85.161.46]) (using TLSv1) by
	exprod7ob118.postini.com ([64.18.6.12]) with SMTP
	ID DSNKTjHQSPLqJVG4x7D6e6XNoPB8ezx46N3K@postini.com;
	Thu, 28 Jul 2011 14:10:34 PDT
Received: by mail-fx0-f46.google.com with SMTP id 19so2315835fxh.33
	for <pgsql-hackers@postgresql.org>;
	Thu, 28 Jul 2011 14:10:32 -0700 (PDT)
Received: by 10.223.154.140 with SMTP id o12mr97903faw.142.1311887432342;
	Thu, 28 Jul 2011 14:10:32 -0700 (PDT)
Received: from [192.168.1.183] (dsl-hkibrasgw2-ff7ac300-240.dhcp.inet.fi
	[88.195.122.240])
	by mx.google.com with ESMTPS id n18sm705844fam.7.2011.07.28.14.10.30
	(version=TLSv1/SSLv3 cipher=OTHER);
	Thu, 28 Jul 2011 14:10:31 -0700 (PDT)
Message-ID: <4E31D03D.70206@enterprisedb.com>
Date: Fri, 29 Jul 2011 00:10:21 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI;
	rv:1.9.2.18) Gecko/20110626 Icedove/3.1.11
MIME-Version: 1.0
To: Alexander Korotkov <aekorotkov@gmail.com>
CC: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: WIP: Fast GiST index build
References: <BANLkTikgOQ1+r=A9b08szNTeEWsk-cNMMg@mail.gmail.com>
	<CAPpHfdt6ER8LKEEmnVnbYuaODKpDb4S5UuGRa5prio--Kp=LFw@mail.gmail.com>
	<26338.1310134685@sss.pgh.pa.us>
	<CAPpHfduE1LM7aCk7MZ_u_n2z58Jxps=TBD0eX4WX4gwBrkk=Yw@mail.gmail.com>
	<CAPpHfdvcAo2L2RVtnr+BtPE18Q4mJLaLf-R7SrKMTUousv8ChA@mail.gmail.com>
	<4E1DA4CB.9020209@enterprisedb.com>
	<CAPpHfdvSC3p7zR_BwbNhm+3fvg8b-rwe+p=HJ9Gii8_rethbuw@mail.gmail.com>
	<4E1EABD9.5000308@enterprisedb.com>
	<CAPpHfdsO3BBEXzBwcrVGHXE=dYUOhQ+corT3gLLtCkjNXacHoQ@mail.gmail.com>
	<CAPpHfdv=V+UGFyq=EJeLUzxygN3m63H0yocX4jsAmEBha7NKRw@mail.gmail.com>
	<4E1F5763.9090109@enterprisedb.com>
	<CAPpHfdszFQ7KyWurN7+AMSdG-v4m-p=HgpLPH=XUZqbnGJf+og@mail.gmail.com>
	<CAPpHfdtVJJyinb1TuFF3gw6-YLre2O9svUZgZGAWzogXswP6Bg@mail.gmail.com>
	<CAPpHfdvoOh78ycX3eRePTS29635pHCSTfLdFDzHZhxTKsggCuQ@mail.gmail.com>
	<4E2DBB60.80604@enterprisedb.com>
	<4E2EF83A.8000304@enterprisedb.com>
	<CAPpHfdso-oOo4+3r9yBn=PATz3BC4z4cxK9Ew8tFRT1MkVVoiA@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdso-oOo4+3r9yBn=PATz3BC4z4cxK9Ew8tFRT1MkVVoiA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-1.9 tagged_above=-5 required=5 tests=BAYES_00=-1.9
X-Spam-Level: 
X-Archive-Number: 201107/1571
X-Sequence-Number: 192670

On 28.07.2011 23:57, Alexander Korotkov wrote:
> On Tue, Jul 26, 2011 at 9:24 PM, Heikki Linnakangas<
> heikki.linnakangas@enterprisedb.com>  wrote:
>>
>> Let me know if you have questions on the approach taken.
>
>
> I realized that approach which comes as replace to loaded-subtrees keeping
> is unclear to me. We save paths between node buffers. But those paths can
> become invalid on page splits. It seems to me that approximately same volume
> of code for maintaining parent links should be added to this version of
> patch in order to get it working correctly.

gistFindCorrectParent() should take care of that.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com