Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: David Christensen <david.christensen@crunchydata.com>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Date: Fri, 4 Nov 2022 09:16:29 -0500
Message-Id: <4E379ADE-1FC3-4D53-BE46-562BDC77C5FE@crunchydata.com>
References: <20221104140238.GA16921@telsasoft.com>
Cc: Ian Lawrence Barwick <barwick@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>,
 pgsql-hackers@postgresql.org
In-Reply-To: <20221104140238.GA16921@telsasoft.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/4E379ADE-1FC3-4D53-BE46-562BDC77C5FE%40crunchydata.com>
Precedence: bulk

On Nov 4, 2022, at 9:02 AM, Justin Pryzby <pryzby@telsasoft.com> wrote:
>=20
> =EF=BB=BFOn Fri, Nov 04, 2022 at 11:52:59AM +0900, Ian Lawrence Barwick wr=
ote:
>> 2022=E5=B9=B45=E6=9C=883=E6=97=A5(=E7=81=AB) 8:45 David Christensen <davi=
d.christensen@crunchydata.com>:
>>>=20
>>> ...and pushing a couple fixups pointed out by cfbot, so here's v4.
>>=20
>> cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is
>> currently underway, this would be an excellent time to update the patch.
>=20
> More important than needing to be rebased, the patch has never passed
> its current tests on windows.
>=20
> As I recall, that's due to relying on "cp".  And "rsync", which
> shouldn't be assumed to exist by regression tests).

I will work on supporting the windows compatibility here. Is there some list=
 of guidelines for what you can and can=E2=80=99t use? I don=E2=80=99t have a=
 windows machine available to develop on.=20

Was it failing on windows? I was attempting to skip it as I recall.=20

Best,

David