Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id 27B16B5DC13 for ; Wed, 21 Sep 2011 16:38:37 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 54923-02 for ; Wed, 21 Sep 2011 19:38:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0-rc2 Received: from exprod7og114.obsmtp.com (exprod7og114.obsmtp.com [64.18.2.215]) by mail.postgresql.org (Postfix) with ESMTP id EB5E2B5DBD1 for ; Wed, 21 Sep 2011 16:38:28 -0300 (ADT) Received: from mail-fx0-f52.google.com ([209.85.161.52]) (using TLSv1) by exprod7ob114.postini.com ([64.18.6.12]) with SMTP ID DSNKTno9M1KBBTZbZOAL8p7qV4XDWTp3epYz@postini.com; Wed, 21 Sep 2011 12:38:29 PDT Received: by fxe23 with SMTP id 23so1907125fxe.25 for ; Wed, 21 Sep 2011 12:38:26 -0700 (PDT) Received: by 10.223.56.67 with SMTP id x3mr1595659fag.64.1316633906304; Wed, 21 Sep 2011 12:38:26 -0700 (PDT) Received: from [192.168.1.183] (dsl-hkibrasgw2-ff7ac300-240.dhcp.inet.fi. [88.195.122.240]) by mx.google.com with ESMTPS id m26sm5168605fac.6.2011.09.21.12.38.24 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 21 Sep 2011 12:38:25 -0700 (PDT) Message-ID: <4E7A3D2E.9040901@enterprisedb.com> Date: Wed, 21 Sep 2011 22:38:22 +0300 From: Heikki Linnakangas User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI; rv:1.9.2.21) Gecko/20110831 Icedove/3.1.13 MIME-Version: 1.0 To: Oleg Bartunov CC: Pgsql Hackers Subject: Re: WIP: SP-GiST, Space-Partitioned GiST References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.9 tagged_above=-5 required=5 tests=BAYES_00=-1.9 X-Spam-Level: X-Archive-Number: 201109/1082 X-Sequence-Number: 195271 On 05.09.2011 09:39, Oleg Bartunov wrote: > I attached wrong patch in previous message, sorry ! Here is a last version. One little detail caught my eye: In spgSplitNodeAction, you call SpGistGetBuffer() within a critical section. That should be avoided, SpGistGetBuffer() can easily fail if you e.g run out of disk space. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com