Message-ID: <4E7B1A7C.80103@enterprisedb.com>
Date: Thu, 22 Sep 2011 14:22:36 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI;
	rv:1.9.2.21) Gecko/20110831 Icedove/3.1.13
MIME-Version: 1.0
To: Alexander Korotkov <aekorotkov@gmail.com>
CC: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Double sorting split patch
References: 
 <CAPpHfdtkUfgdMwTsoNUiaKUM3HBQre1iZFiHjR2umqgTf5D_dQ@mail.gmail.com>
	<4E72197B.9040602@enterprisedb.com>
	<CAPpHfdu+7RKA+jF4ek9CjAiAbCV=v666AMffg2RyvFnvKdbuyQ@mail.gmail.com>
	<4E732DFF.9070900@enterprisedb.com>
	<CAPpHfdsYROQbYw1kME0aro=ygLTGd8pKgYFh6GnVPO7VJTW2ew@mail.gmail.com>
	<4E74D21C.2070503@enterprisedb.com>
	<CAPpHfdsfXiQib=Jd2C4obuPQpoQ-CDPskbL-VaOaZd4uAoCOBw@mail.gmail.com>
	<CAPpHfds1YZSg6tdUrX+bFS3q=NFN+sSVx_awvbb0hKupUrmQ-g@mail.gmail.com>
In-Reply-To: 
 <CAPpHfds1YZSg6tdUrX+bFS3q=NFN+sSVx_awvbb0hKupUrmQ-g@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

> ! 		/*
> ! 		 * Calculate delta between penalties of join "common entries" to
> ! 		 * different groups.
> ! 		 */
> ! 		for (i = 0; i < commonEntriesCount; i++)
>   		{
> ! 			double		lower,
> ! 						upper;
> !
> ! 			box = DatumGetBoxP(entryvec->vector[commonEntries[i].index].key);
> ! 			if (context.dim == 0)
> ! 			{
> ! 				lower = box->low.x;
> ! 				upper = box->high.x;
> ! 			}
> ! 			else
> ! 			{
> ! 				lower = box->low.y;
> ! 				upper = box->high.y;
> ! 			}
> ! 			commonEntries[i].delta = Abs(box_penalty(leftBox, box) -
> ! 										 box_penalty(rightBox, box));
>   		}

'lower' and 'upper' are not used for anything in the above. Is that just 
dead code that can be removed, or is there something missing that should 
be using them?

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com