Received: from maia.hub.org (maia-5.hub.org [200.46.204.29])
	by mail.postgresql.org (Postfix) with ESMTP id 4B653B5DC0F
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Thu,  6 Oct 2011 07:19:23 -0300 (ADT)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024)
	with ESMTP id 17807-02
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Thu,  6 Oct 2011 10:19:17 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.8.0-rc2
Received: from exprod7og114.obsmtp.com (exprod7og114.obsmtp.com [64.18.2.215])
	by mail.postgresql.org (Postfix) with ESMTP id 4A375B5DC04
	for <pgsql-hackers@postgresql.org>;
	Thu,  6 Oct 2011 07:19:16 -0300 (ADT)
Received: from mail-ey0-f179.google.com ([209.85.215.179]) (using TLSv1) by
	exprod7ob114.postini.com ([64.18.6.12]) with SMTP;
	Thu, 06 Oct 2011 03:19:17 PDT
Received: by mail-ey0-f179.google.com with SMTP id 5so2403326eyh.10
	for <pgsql-hackers@postgresql.org>;
	Thu, 06 Oct 2011 03:19:15 -0700 (PDT)
Received: by 10.223.5.139 with SMTP id 11mr2667494fav.21.1317896355442;
	Thu, 06 Oct 2011 03:19:15 -0700 (PDT)
Received: from [192.168.1.183] (dsl-hkibrasgw2-ff7ac300-240.dhcp.inet.fi.
	[88.195.122.240])
	by mx.google.com with ESMTPS id o22sm6494169fab.11.2011.10.06.03.19.12
	(version=TLSv1/SSLv3 cipher=OTHER);
	Thu, 06 Oct 2011 03:19:13 -0700 (PDT)
Message-ID: <4E8D809F.7070304@enterprisedb.com>
Date: Thu, 06 Oct 2011 13:19:11 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI;
	rv:1.9.2.21) Gecko/20110831 Icedove/3.1.13
MIME-Version: 1.0
To: Alexander Korotkov <aekorotkov@gmail.com>
CC: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Double sorting split patch
References: 
 <CAPpHfdtkUfgdMwTsoNUiaKUM3HBQre1iZFiHjR2umqgTf5D_dQ@mail.gmail.com>
	<CAPpHfdsYROQbYw1kME0aro=ygLTGd8pKgYFh6GnVPO7VJTW2ew@mail.gmail.com>
	<4E74D21C.2070503@enterprisedb.com>
	<CAPpHfdsfXiQib=Jd2C4obuPQpoQ-CDPskbL-VaOaZd4uAoCOBw@mail.gmail.com>
	<CAPpHfds1YZSg6tdUrX+bFS3q=NFN+sSVx_awvbb0hKupUrmQ-g@mail.gmail.com>
	<4E7B1A7C.80103@enterprisedb.com>
	<CAPpHfdtf_sKufPJZ0XrOba8zcsWApBWUaqAPRv39niSEQYdrdA@mail.gmail.com>
	<CAPpHfdt6MO0Q9JgVXvYuf1Oe_ge_CqjCQ+ynAvYM-zEfVcEQiw@mail.gmail.com>
	<4E8AC009.5040806@enterprisedb.com>
	<CAPpHfds333E_V28nRkDY2CBSDC+TDHykZ1HBdPpYkGAjb9w6dg@mail.gmail.com>
	<4E8AD603.80506@enterprisedb.com>
	<CAPpHfds61VsxWhr4wRMZ=J4Ozp3seoS-S9bYv5Cd9Uc_UTDz+Q@mail.gmail.com>
	<4E8C091C.6020908@enterprisedb.com>
	<CAPpHfdtShbuHCooS+mPndHKubXbFVu1=XUDMibqKot+j8q3gxw@mail.gmail.com>
	<CAPpHfdvt-8vkD3p5wUCH0A3fCWtmgKxzG6bp23K4aBvOrS5Vxw@mail.gmail.com>
	<4E8D5393.2000900@enterprisedb.com>
	<CAPpHfdtJL16zZ2uwD5LD8TnkchV-TFaLbYJeGk0ZkhcFb=KeDA@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdtJL16zZ2uwD5LD8TnkchV-TFaLbYJeGk0ZkhcFb=KeDA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-1.9 tagged_above=-5 required=5 tests=BAYES_00=-1.9
X-Spam-Level: 
X-Archive-Number: 201110/275
X-Sequence-Number: 196081

On 06.10.2011 11:22, Alexander Korotkov wrote:
> Thanks. I'm going to continue work on application of this split method in
> following areas:
> 1) range types
> 2) seg contrib module
> 3) cube contrib module (there situation is not so easy, probably some
> heuristic of split method selection would be required)
> Do you think that separation of some common parts of algorithm implemetation
> is resonable in order to avoid code duplication? For example, different
> application of algorithm could share function of splits enumeration along
> axis which takes pointer to consider_split as an argument.

Dunno. I'd suggest that you just copy-paste the code for now, and we'll 
see how much duplication there is in the end.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com