Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id E8F38B5DBD9 for ; Tue, 11 Oct 2011 09:38:58 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 11140-08 for ; Tue, 11 Oct 2011 12:38:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0-rc2 Received: from mail-ey0-f174.google.com (mail-ey0-f174.google.com [209.85.215.174]) by mail.postgresql.org (Postfix) with ESMTP id 124D5B5D803 for ; Tue, 11 Oct 2011 09:38:50 -0300 (ADT) Received: by eye27 with SMTP id 27so2475449eye.19 for ; Tue, 11 Oct 2011 05:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=c+Bs+tm6agMRWzdWKr3wITdmeuFeHHdkxnkO1dyVcOQ=; b=X97wFJdUbOWHKPB+4dJBPMD53SUjWxLVs0K/WXzFeQ8XxlZOxJ9/2RPnwWG12lGKUI r5Zt5rZLkBCNZqkgeIPKunreo4zlIEfrcLsprRS2Hb3tSZOhswQAX+nAyceK214FSjA1 SFNdw1/GXo6sY2DF+1yUEiEdASSqA2c6sZxsk= Received: by 10.14.2.93 with SMTP id 69mr2113201eee.62.1318336726507; Tue, 11 Oct 2011 05:38:46 -0700 (PDT) Received: from [192.168.73.63] (5357DA75.cm-6-8d.dynamic.ziggo.nl. [83.87.218.117]) by mx.google.com with ESMTPS id t2sm48498349eef.10.2011.10.11.05.38.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Oct 2011 05:38:42 -0700 (PDT) Message-ID: <4E9438CD.20100@gmail.com> Date: Tue, 11 Oct 2011 14:38:37 +0200 From: Yeb Havinga User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Royce Ausburn CC: Pg Hackers Subject: Re: [REVIEW] Patch for cursor calling with named parameters References: <4E8ED2A7.2040800@gmail.com> <4E8F1315.70109@gmail.com> <29A8127B-BB37-40DC-8FB6-833710DAB22C@inomial.com> In-Reply-To: <29A8127B-BB37-40DC-8FB6-833710DAB22C@inomial.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.899 tagged_above=-5 required=5 tests=BAYES_00=-1.9, FREEMAIL_FROM=0.001 X-Spam-Level: X-Archive-Number: 201110/572 X-Sequence-Number: 196378 Hello Royce, Thanks again for testing. On 2011-10-11 13:55, Royce Ausburn wrote: > Just one small thing: it'd be nice to have an example for cursor declaration with named parameters. Your patch adds one for opening a cursor, but not for declaring one. Declaration of cursors with named parameters is already part of PostgreSQL (so it is possible to use the parameter names in the cursor query instead of $1, $2, etc.) and it also already documented with an example, just a few lines above the open examples. See curs3 on http://developer.postgresql.org/pgdocs/postgres/plpgsql-cursors.html > Other than that, I think the patch is good. Everything works as advertised =) Thanks! -- Yeb Havinga http://www.mgrid.net/ Mastering Medical Data