Received: from maia.hub.org (maia-3.hub.org [200.46.204.243])
	by mail.postgresql.org (Postfix) with ESMTP id 2AD5EB5DC0F
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Mon, 17 Oct 2011 05:44:47 -0300 (ADT)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia,
	port 10024) with ESMTP id 93431-03
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Mon, 17 Oct 2011 08:44:41 +0000 (UTC)
X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0-rc2
Received: from mail-ey0-f174.google.com (mail-ey0-f174.google.com
	[209.85.215.174])
	by mail.postgresql.org (Postfix) with ESMTP id A3367B5DC04
	for <pgsql-hackers@postgresql.org>;
	Mon, 17 Oct 2011 05:44:40 -0300 (ADT)
Received: by eye27 with SMTP id 27so2727304eye.19
	for <pgsql-hackers@postgresql.org>;
	Mon, 17 Oct 2011 01:44:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=9hAtufC5UlTGZY8n2H0wFA9OBEe/kf8x7fGR+odvYw0=;
	b=L8XmPnbRozgQP7/6TnicJt1FJSEalUM428TOxZAZ5tBJf4RNh6MFGcHl2OdLQ/P/Qr
	Kw1xcfAtrBvlgwi6HRuoHYWC9hBNbYrUGumm6OSMV70R6CN17Hsx/nOibDTecwgxVmya
	tR3/zXix83ZhHEXN1TFWejOUZl6uCbs2A4yag=
Received: by 10.14.17.78 with SMTP id i54mr706021eei.71.1318841079418;
	Mon, 17 Oct 2011 01:44:39 -0700 (PDT)
Received: from [192.168.73.63] (5357DA75.cm-6-8d.dynamic.ziggo.nl.
	[83.87.218.117])
	by mx.google.com with ESMTPS id y11sm27233974eej.5.2011.10.17.01.44.38
	(version=TLSv1/SSLv3 cipher=OTHER);
	Mon, 17 Oct 2011 01:44:38 -0700 (PDT)
Message-ID: <4E9BEAF6.6000001@gmail.com>
Date: Mon, 17 Oct 2011 10:44:38 +0200
From: Yeb Havinga <yebhavinga@gmail.com>
User-Agent: Mozilla/5.0 (Windows NT 5.1;
	rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: Royce Ausburn <royce.ml@inomial.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [REVIEW] Patch for cursor calling with named parameters
References: <FCEADDEF-8563-4965-8D4A-E37F2328C42B@inomial.com>
	<4E8ED2A7.2040800@gmail.com> <4E8F1315.70109@gmail.com>
	<29A8127B-BB37-40DC-8FB6-833710DAB22C@inomial.com>
	<4E9438CD.20100@gmail.com> <5928.1318657260@sss.pgh.pa.us>
In-Reply-To: <5928.1318657260@sss.pgh.pa.us>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-1.899 tagged_above=-5 required=5 tests=BAYES_00=-1.9,
	FREEMAIL_FROM=0.001
X-Spam-Level: 
X-Archive-Number: 201110/944
X-Sequence-Number: 196750

On 2011-10-15 07:41, Tom Lane wrote:
> Yeb Havinga<yebhavinga@gmail.com>  writes:
>> Hello Royce,
>> Thanks again for testing.
> I looked this patch over but concluded that it's not ready to apply,
> mainly because there are too many weird behaviors around error
> reporting.

Tom, thanks for reviewing - getting the syntax errors to be at the exact 
location was indeed something that I thought would be near impossible, 
however the whitespace suggestion together with the others you made seem 
like a good path to go forward. Thanks for taking the time to write your 
comments, it will be a great help with making an improved version.

regards,
Yeb Havinga