Received: from magus.postgresql.org (magus.postgresql.org [87.238.57.229])
	by mail.postgresql.org (Postfix) with ESMTP id B9CF8723EDA
	for <pgsql-hackers@postgresql.org>;
	Sun, 20 Nov 2011 14:22:42 -0400 (AST)
Received: from wulczer.org ([109.74.195.157])
	by magus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <wulczer@wulczer.org>) id 1RSC2I-0004ty-81
	for pgsql-hackers@postgresql.org; Sun, 20 Nov 2011 18:22:41 +0000
Received: from [85.59.228.11] (helo=[10.0.0.101])
	by wulczer.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.72) (envelope-from <wulczer@wulczer.org>)
	id 1RSC24-0001Cj-IM; Sun, 20 Nov 2011 18:22:24 +0000
Message-ID: <4EC9455F.5070209@wulczer.org>
Date: Sun, 20 Nov 2011 19:22:23 +0100
From: =?UTF-8?B?SmFuIFVyYmHFhHNraQ==?= <wulczer@wulczer.org>
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:8.0) Gecko/20111105 Thunderbird/8.0
MIME-Version: 1.0
To: Steve Singer <ssinger_pg@sympatico.ca>
CC: Postgres - Hackers <pgsql-hackers@postgresql.org>
Subject: Re: plpython SPI cursors
References: <4E9A1738.6090108@wulczer.org>
	<BLU0-SMTP4530C1907601DFB9AEAE778ECA0@phx.gbl>
In-Reply-To: <BLU0-SMTP4530C1907601DFB9AEAE778ECA0@phx.gbl>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Archive-Number: 201111/1208
X-Sequence-Number: 198693

On 20/11/11 19:14, Steve Singer wrote:
> On 11-10-15 07:28 PM, Jan Urbański wrote:
>> Hi,
>>
>> attached is a patch implementing the usage of SPI cursors in PL/Python.

> I found a few bugs (see my testing section below) that will need fixing
> + a few questions about the code

Hi Steve,

thanks a lot for the review, I'll investigate the errors you were 
getting and post a follow-up.

Good catch on trying cursors with explicit subtransactions, I didn't 
think about how they would interact.

Cheers,
Jan