Message-ID: <4ECE5FA5.6060506@enterprisedb.com>
Date: Thu, 24 Nov 2011 17:15:49 +0200
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI;
	rv:1.9.2.23) Gecko/20111010 Icedove/3.1.15
MIME-Version: 1.0
To: =?UTF-8?B?SmFuIFVyYmHFhHNraQ==?= <wulczer@wulczer.org>
CC: Mika Eloranta <mel@ohmu.fi>, pgsql-hackers@postgresql.org
Subject: Re: PL/Python SQL error code pass-through
References: <0174B71F-7940-4819-BDC8-95EC8C9BA833@ohmu.fi>
	<4ECDFB26.1090203@wulczer.org>
In-Reply-To: <4ECDFB26.1090203@wulczer.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 24.11.2011 10:07, Jan Urbański wrote:
> On 23/11/11 17:24, Mika Eloranta wrote:
>> Hi all,
>>
>> [PL/Python in 9.1 does not preserve SQLSTATE of errors]
>
> Oops, you're right, it's a regression from 9.0 behaviour.
>
> The fix looks good to me, I changed one place to indent with tabs
> instead of spaces and added a regression test.

Thank you, both. Is there some other fields that we should propagate 
from the original error message that we're missing? Like, context and 
file/line information? Or are those left out on purpose? I wonder if we 
should have a more wholesale approach, and store the whole ErrorData 
struct somewhere, and only add some extra context information with 
errcontext().

> I think this should be backpatched to 9.1, no?

Yeah, it should. Your patch probably makes most sense for backpatching, 
even if we do something more radical on master.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com