Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125]) by mail.postgresql.org (Postfix) with ESMTP id 3BBDD3C1FBB for ; Sun, 11 Dec 2011 11:26:51 -0400 (AST) Received: from mail-ey0-f174.google.com ([209.85.215.174]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1RZlIg-0007H0-CT for pgsql-hackers@postgresql.org; Sun, 11 Dec 2011 15:26:51 +0000 Received: by eaaj10 with SMTP id j10so191461eaa.19 for ; Sun, 11 Dec 2011 07:26:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=reRYWc7KDeG22uhIRGls80VAZ4arCQKK94blBT9aRaY=; b=JR3p+WOOzGP2PXKAkWoKVrBlxRoBjWDABdrBZwPtzt+CC1eWsOj5YXpOmgAYjpcWJW zYFAR3vRuXWnahmsQGSeF1YOjND0h3NnyB5uGYyljQyrvxqNxgkXV/0DeLTQrj5z1K47 KAyGcT01QAOadhr3EsZFUuPRSF5cJv+egUULQ= Received: by 10.213.29.202 with SMTP id r10mr2871576ebc.52.1323617197321; Sun, 11 Dec 2011 07:26:37 -0800 (PST) Received: from [192.168.73.63] (5357DA75.cm-6-8d.dynamic.ziggo.nl. [83.87.218.117]) by mx.google.com with ESMTPS id 58sm62384515eet.11.2011.12.11.07.26.35 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 11 Dec 2011 07:26:36 -0800 (PST) Message-ID: <4EE4CBA9.2020507@gmail.com> Date: Sun, 11 Dec 2011 16:26:33 +0100 From: Yeb Havinga User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Kevin Grittner CC: pgsql-hackers@postgresql.org Subject: Re: [REVIEW] Patch for cursor calling with named parameters References: <4EDA37F7020000250004380D@gw.wicourts.gov> <4EDC97B7.6030508@gmail.com> <4EDC9042020000250004382F@gw.wicourts.gov> <4EDDF56D0200002500043914@gw.wicourts.gov> In-Reply-To: <4EDDF56D0200002500043914@gw.wicourts.gov> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) X-Archive-Number: 201112/421 X-Sequence-Number: 199673 On 2011-12-06 17:58, Kevin Grittner wrote: > Kevin Grittner wrote: >> Yeb Havinga wrote: > >>> I personally tend to believe it doesn't even need to be an error. >>> There is no technical reason not to allow it. All the user needs >>> to do is make sure that the combination of named parameters and >>> the positional ones together are complete and not overlapping. > >> If there are no objections, I suggest that Yeb implement the mixed >> notation for cursor parameters. > > Hearing no objections -- Yeb, are you OK with doing this, and do you > feel this is doable for this CF? Attach is v6 of the patch, allowing mixed mode and with new test cases in the regression tests. One difference with calling functions remains: it is allowed to place positional arguments after named parameters. Including that would add code, but nothing would be gained. regards, Yeb Havinga