Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\))
Subject: Re: Issue with cancel_before_shmem_exit while searching to remove a
 particular registered exit callbacks
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <CA+TgmobdNtd+6gr2zFH6mTSDoNAwYNt=z=Jr1h59vM+PYrbQeQ@mail.gmail.com>
Date: Thu, 16 Nov 2023 22:05:19 +0100
Cc: Andres Freund <andres@anarazel.de>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <4EF5DD92-15E2-413F-AD6D-C2D29C98D29D@yesql.se>
References: <CALj2ACWk7j4F2v2fxxYfrroOF=AdFNPr1WsV+AGtHAFQOqm_pw@mail.gmail.com>
 <1519052.1594129481@sss.pgh.pa.us>
 <20200707165445.6qniqhzydlfsplvw@alap3.anarazel.de>
 <CA+TgmoZDFyV1RAmTEKvjaV8TvvS+gKha+RRiJUGMOLoY0-8Ekw@mail.gmail.com>
 <CA+TgmobdNtd+6gr2zFH6mTSDoNAwYNt=z=Jr1h59vM+PYrbQeQ@mail.gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/4EF5DD92-15E2-413F-AD6D-C2D29C98D29D%40yesql.se>
Precedence: bulk

> On 30 Jul 2020, at 14:11, Robert Haas <robertmhaas@gmail.com> wrote:
>=20
> On Mon, Jul 20, 2020 at 3:47 PM Robert Haas <robertmhaas@gmail.com> =
wrote:
>> But I also agree that what pg_start_backup() was doing before v13 was
>> wrong; that's why I committed
>> 303640199d0436c5e7acdf50b837a027b5726594. The only reason I didn't
>> back-patch it is because the consequences are so minor I didn't think
>> it was worth worrying about. We could, though. I'd be somewhat
>> inclined to both do that and also change LLVM to use on_proc_exit() =
in
>> master, but I don't feel super-strongly about it.
>=20
> Unless somebody complains pretty soon, I'm going to go ahead and do
> what is described above.

When backpatching 9dce22033d5d I ran into this in v13 and below, since =
it needs
llvm_shutdown to happen via on_proc_exit in order for all =
llvm_release_context
calls to have finished.  Unless anyone objects I will backpatch =
bab150045bd97
to v12 and v13 as part of my backpatch.

--
Daniel Gustafsson