Received: from magus.postgresql.org (magus.postgresql.org [87.238.57.229]) by mail.postgresql.org (Postfix) with ESMTP id D1926470849 for ; Sat, 14 Jan 2012 21:18:48 -0400 (AST) Received: from moutng.kundenserver.de ([212.227.126.171]) by magus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1RmEk9-000734-JC for pgsql-hackers@postgresql.org; Sun, 15 Jan 2012 01:18:47 +0000 Received: from [192.168.1.6] (mail.highperformancepostgresql.com [71.179.240.8]) by mrelayeu.kundenserver.de (node=mreu4) with ESMTP (Nemesis) id 0LywdQ-1Shce82FiS-014GmH; Sun, 15 Jan 2012 02:18:32 +0100 Message-ID: <4F122967.6070400@2ndQuadrant.com> Date: Sat, 14 Jan 2012 20:18:31 -0500 From: Greg Smith User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111120 Icedove/3.1.16 MIME-Version: 1.0 To: pgsql-hackers@postgresql.org Subject: Re: xlog location arithmetic References: <4EDD97E5.8080201@timbira.com> <4F118D45.3060801@timbira.com> In-Reply-To: <4F118D45.3060801@timbira.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:L5aWECKFIqo4VyquvCAvW/UTeZGingmsJETRSpYCa/N uE8FICQsrtKsizw5DY588f/S7uLZUne6oJdRG6MXHFJXNnJpPI zY3eD4Klp3v8cROf8ot1ucvdKVHTxvvYfyxzTLHpZ9d2+1SXMF hBNKArlDOyRC73IH0kf34uB4xUNzcPh/32UZ/kA6E8+9Vgo9fM 6wms5iCZuU1exKSg3SOxQkvtY0brypwGKJlkZqKCpwj0dDiod9 jinTIfNPOctCxKmJ4SPu++o7b/hpN4r1x7QEYxozE6NBk3ptJR V7alWlNGKttG5N8a0yd9cfaOO2ai2VYT0bIALjaPQjYnUdDtP/ pp6b4KG7nuiapYq+bUUY= X-Pg-Spam-Score: -1.9 (-) X-Archive-Number: 201201/762 X-Sequence-Number: 201352 On 01/14/2012 09:12 AM, Euler Taveira de Oliveira wrote: > But I must adjust the patch based on the thread comments (basically, > numeric output). I have a new patch but need to test it before submitting it. > I'll post this weekend. It's now at https://commitfest.postgresql.org/action/patch_view?id=776 listed as waiting on you right now. It's good to put patches into the CF application early. Helps planning, and gives a safety net against all sorts of things. We wouldn't want something this obviously useful to get kicked out if, for example, you lost your Internet connection over the weekend and then didn't technically qualify as having submitted it there before the deadline. As someone who sweated today for two hours when my power at home was turned off to install a new circuit breaker, I'm feeling particularly paranoid right now about that sort of thing here. The fact that you got some review feedback before the official CF start doesn't mean you can't be listed there right now. In fact, those are things I like to see tracked. Having links to all of the e-mail messages that were important turning points for a feature that changed during review is very helpful to reviewers and committers. And the easiest way to keep up with that is to start as early as possible: add it to the app right after the first patch submission. -- Greg Smith 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com