Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125]) by mail.postgresql.org (Postfix) with ESMTP id C79961DA4C1F for ; Tue, 17 Jan 2012 14:19:30 -0400 (AST) Received: from moutng.kundenserver.de ([212.227.126.186]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1RnDd0-0000Ex-Qq for pgsql-hackers@postgresql.org; Tue, 17 Jan 2012 18:19:31 +0000 Received: from [192.168.1.6] (mail.highperformancepostgresql.com [71.179.240.8]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0LjweT-1SOC4W3UPR-00bTRH; Tue, 17 Jan 2012 19:19:14 +0100 Message-ID: <4F15BBA1.5010701@2ndQuadrant.com> Date: Tue, 17 Jan 2012 13:19:13 -0500 From: Greg Smith User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111120 Icedove/3.1.16 MIME-Version: 1.0 To: Peter Eisentraut CC: pgsql-hackers@postgresql.org Subject: Re: automating CF submissions (was xlog location arithmetic) References: <4EDD97E5.8080201@timbira.com> <4F118D45.3060801@timbira.com> <4F122967.6070400@2ndQuadrant.com> <4F125998.5020204@2ndQuadrant.com> <4F148D29.7080504@agliodbs.com> <4F14A3EE.8000402@2ndQuadrant.com> <1326819026.2820.1.camel@vanquo.pezone.net> In-Reply-To: <1326819026.2820.1.camel@vanquo.pezone.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:ngLrr5XjQGRChSEzZYwjANkueZ36wE2L7aeKE/Hf7wk 7EHEU4XsVG5SxgmSoi9LNHUVKJlH4mHWQInCC+ACPeAi9SgPEq zgq8ZlqBUjzP4ti+ljD1sAFLCAQXDvmEHXY1P62YmfXlb6E9k5 eRdUBlk5WnCP9LShzPXSZr8QUYyhq17yL1l3rx/UrEguIsi41A eV/sSzuqLTNrzcxauRuSODJOxhZsl36NyOkhwUz/kAY0kOaIMt osKP2kC/g9aw955iRvn6htvCdF75sPEHAqtxGierzLYmBA+D9H 18R/INGGwy9oe2BImMFShMnhuQSTuFO5+MaQDoDM71E3jO90M2 BO4WRFVug+mZsIldGCdA= X-Pg-Spam-Score: -1.9 (-) X-Archive-Number: 201201/939 X-Sequence-Number: 201528 On 01/17/2012 11:50 AM, Peter Eisentraut wrote: > On mån, 2012-01-16 at 17:25 -0500, Greg Smith wrote: >> The most reasonable answer to this is for people to publish a git repo >> URL in addition to the "official" submission of changes to the list in >> patch form. > Note that the original complaint was that for the occasional reviewer, > the current system takes at least 5 partially redundant steps in two > different systems. I doubt that adding a third system and more > partially redundant steps it going to help that. Publishing the submission via git is an extra step for the patch submitter. If that happens, the reviewer can test just be cloning that, instead of first closing the PostgreSQL one then applying the patch. It removes the "how do I fish the patch out of the archives?" problem from the reviewer's side of things. -- Greg Smith 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com