Message-ID: <4F280EFE.1080604@2ndQuadrant.it>
Date: Tue, 31 Jan 2012 16:55:42 +0100
From: Gabriele Bartolini <gabriele.bartolini@2ndQuadrant.it>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
	rv:9.0) Gecko/20111222 Thunderbird/9.0.1
MIME-Version: 1.0
To: Noah Misch <noah@leadboat.com>
CC: Marco Nenciarini <marco.nenciarini@2ndQuadrant.it>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Support for foreign keys with arrays
References: <4EB3DF02.4020604@2ndQuadrant.it>
	<20111117042841.GA20517@tornado.leadboat.com>
	<4EC8CA0F.8040405@2ndQuadrant.it>
	<20111120130526.GD12013@tornado.leadboat.com>
	<4EE31CB9.90005@2ndQuadrant.it>
	<20111212004506.GB10399@tornado.leadboat.com>
	<1326568728.2613.16.camel@greygoo.devise-it.lan>
	<20120121204223.GA2388@tornado.leadboat.com>
In-Reply-To: <20120121204223.GA2388@tornado.leadboat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Noah,

Il 21/01/12 21:42, Noah Misch ha scritto:
> On Sat, Jan 14, 2012 at 08:18:48PM +0100, Marco Nenciarini wrote:
> I greatly like that name; it would still make sense for other 
> aggregate types, should we ever expand its use. Please complete the 
> name change: the documentation, catalog entries, etc should all call 
> them something like "each foreign key constraints" (I don't 
> particularly like that exact wording).
Ok, we'll go with "EACH Foreign Key Constraints" but I would allow the 
synonym "Foreign Key Array", especially in the documentation.
> How about: FOREIGN KEY(col_a, EACH col_b, col_c) REFERENCES pktable 
> (a, b, c)
We really like this syntax. However, as also Simon suggested, we'd go 
for switching to this syntax, but stick to a simpler implementation for 
9.2. We will then be able to expand the functionality, by keeping the 
same syntax, from 9.3.
> To complete the ARRAY -> EACH transition, I would suggest names like 
> CASCADE EACH/SET EACH NULL.
Sounds perfect.

Marco will go through all your comments and will send version 3 shortly.

Thank you,
Gabriele

-- 
  Gabriele Bartolini - 2ndQuadrant Italia
  PostgreSQL Training, Services and Support
  gabriele.bartolini@2ndQuadrant.it | www.2ndQuadrant.it