Message-ID: <4F71BAA2.7080902@enterprisedb.com>
Date: Tue, 27 Mar 2012 16:03:30 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:10.0.3) Gecko/20120324 Icedove/10.0.3
MIME-Version: 1.0
To: Alex <ash@commandprompt.com>
CC: Marko Kreen <markokr@gmail.com>, Daniel Farina <daniel@heroku.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Another review of URI for libpq, v7 submission
References: 
 <CAAZKuFZ6d5aB8Tt-vq=xdCA4xEcLTDYK_d+G2VunpSuuqyKktA@mail.gmail.com>
	<87d38eaq3f.fsf@commandprompt.com>
	<CAAZKuFYKZbXhFyXiQOHx87Qq7MbzhN2iaqN_SFCQu3fkCV6Z7Q@mail.gmail.com>
	<87k42lsgck.fsf@commandprompt.com>
	<20120317145110.GA25172@gmail.com>
	<8762dyuda3.fsf@commandprompt.com>
	<87k42cb9dr.fsf@commandprompt.com>
In-Reply-To: <87k42cb9dr.fsf@commandprompt.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit

On 22.03.2012 23:42, Alex wrote:
> Okay, at last here's v9, rebased against current master branch.

Some quick comments on this patch:

I see a compiler warning:
fe-connect.c: In function ‘conninfo_parse’:
fe-connect.c:4113: warning: unused variable ‘option’

Docs are missing.

I wonder if you should get an error if you try specify the same option 
multiple times. At least the behavior needs to be documented.

Should %00 be forbidden?

The error message is a bit confusing for 
"postgres://localhost?dbname=%XXfoo":
WARNING: ignoring unrecognized URI query parameter: dbname
There is in fact nothing wrong with "dbname", it's the %XX in the value 
that's bogus.

Looking at conninfo_uri_decode(), I think it's missing a bounds check, 
and peeks at two bytes beyond the end of string if the input ends in a '%'.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com