Message-ID: <4F76F7CF.2070908@2ndQuadrant.it>
Date: Sat, 31 Mar 2012 14:25:51 +0200
From: Gabriele Bartolini <gabriele.bartolini@2ndQuadrant.it>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
	rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
To: Gilles Darold <gilles.darold@dalibo.com>
CC: pgsql-hackers@postgresql.org, Magnus Hagander <magnus@hagander.net>,
	Fujii Masao <masao.fujii@gmail.com>, Bernd Helmle <mailings@oopsware.de>,
	Euler Taveira de Oliveira <euler@timbira.com>,
	Marti Raudsepp <marti@juffo.org>
Subject: Re: Patch pg_is_in_backup()
References: <4F26E291.9020605@dalibo.com>
	<CABRT9RAo_xTOVdBAEDqzcP+QvoHa0SZW1Ud1p3vjmA5tJUnYLw@mail.gmail.com>
	<CABUevExm4_a-Yw3pt=weppb5ckzAYZwK3e79m__sznQNjjDveg@mail.gmail.com>
	<4F2B470F.5070107@timbira.com>
	<CAHGQGwEE5Zk05cPeTVWjd+TYce10zemMs_Li7ekkroiFKPj9kw@mail.gmail.com>
	<691525170451D3F76CEF7ED1@apophis.local>
	<CAHGQGwFuqazEaT+YCDUoZe-HwQ-txcq=djgisayyWnHhWn+1aQ@mail.gmail.com>
	<CABUevEzi=Fa5xUDRYUkCX3jeE26Y3F3AsO9T_yZQPUzYANdPpg@mail.gmail.com>
	<4F50E1B0.90808@dalibo.com>
In-Reply-To: <4F50E1B0.90808@dalibo.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Gilles,

    first and foremost, sorry for jumping in this thread so late. I read 
all previous discussions and I'd be happy to help you with this patch.

> Agreed and sorry for the response delay. I've attached 2 patches here, 
> the first one is the same as before with just the renaming of the 
> function into pg_is_in_exclusive_backup().

    My quick response: I really like the idea of having a function that 
simply returns a boolean value. To be honest, I would have called it 
pg_is_in_backup() as you originally did - after all, I do not execute 
pg_start_exclusive_backup() or pg_stop_exclusive_backup(). It is more 
intuitive and pairs with pg_is_in_recovery(). I have never found any 
mention whatsoever in the documentation that talks about exclusive 
backup, and I am afraid it would generate confusion.

    However, I leave this up to the rest of the community's judgement 
(here is my opinion).

    I agree also that a function that returns the timestamp of the start 
of the backup might be useful. My opinion with the 'exclusive' keyword 
applies here too (I would simply name it pg_backup_start_time()).

    Finally, I tried to apply the patch but it looks like we need a new 
version that can apply with current HEAD. If you can do that, I am happy 
to assist with the review.

    Have a good weekend.

Thank you,
Gabriele

-- 
  Gabriele Bartolini - 2ndQuadrant Italia
  PostgreSQL Training, Services and Support
  gabriele.bartolini@2ndQuadrant.it | www.2ndQuadrant.it