Message-ID: <4F7DE01A.80300@enterprisedb.com>
Date: Thu, 05 Apr 2012 21:10:34 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:10.0.3) Gecko/20120324 Icedove/10.0.3
MIME-Version: 1.0
To: Robert Haas <robertmhaas@gmail.com>
CC: Simon Riggs <simon@2ndquadrant.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Pavel Stehule <pavel.stehule@gmail.com>
Subject: Re: Last gasp
References: 
 <CA+U5nML0w7FAM8Wi6W1ObSa160ipN5shg3Z0y91ew-Um8iXxCg@mail.gmail.com>
	<CA+TgmoazMq6FF2otE_5HYJr3nwwEy9_0TmGYu_G3AsY8ckQcjg@mail.gmail.com>
In-Reply-To: 
 <CA+TgmoazMq6FF2otE_5HYJr3nwwEy9_0TmGYu_G3AsY8ckQcjg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 05.04.2012 21:00, Robert Haas wrote:
> Heikki recently produced a revision of the check function patch, but
> I'm not sure whether he's planning to commit that or whether it's a
> demonstration of a broader rework he wants Pavel (or someone else) to
> do.  At any rate, I think it's up to him whether or not to commit
> that.

Yeah, I guess it's up to me, now that I've touched that code. I don't 
feel ready to commit it yet. It needs some more cleanup, which I could 
do, but frankly even with the refactoring I did I'm still not totally 
happy with the way it works. I feel that there ought to be a less 
duplicative approach, but I don't have any more concrete proposals. 
Unless someone more motivated picks up the patch now, I think it needs 
to be pushed to 9.3.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com