From: Chao Li <li.evan.chao@gmail.com>
Message-Id: <4FD8124D-6D42-4481-9C41-B658E5378364@gmail.com>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_CF927418-4819-48BF-BF12-A1CBE8B7E881"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\))
Subject: Re: Set notice receiver before libpq connection startup
Date: Thu, 28 May 2026 08:39:48 +0800
In-Reply-To: <2620a664-7b44-48b2-9aa8-5f0131702d9c@eisentraut.org>
Cc: Fujii Masao <masao.fujii@gmail.com>,
 Rafia Sabih <rafia.pghackers@gmail.com>,
 vignesh C <vignesh21@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
To: Peter Eisentraut <peter@eisentraut.org>
References: <A2B8B7DE-C119-492F-A9FA-14CF86849777@gmail.com>
 <CAHGQGwHnz7FoSx+qQsAHBx_j8Tks+SC-kAPTevrKYfrL08Ee9Q@mail.gmail.com>
 <978D8971-08C3-4AAD-AE8B-976D753C882A@gmail.com>
 <CALDaNm3UyoQ91gW2bRP4PXnnfAv3GfmCik614-AtQCiEUAjQYw@mail.gmail.com>
 <6B9A85F9-B632-4286-98AF-9EC435019055@gmail.com>
 <CA+FpmFdfyBhuiou1uqe94UR3WCg57wM5FsooUx2w27aABGoyag@mail.gmail.com>
 <CAHGQGwHU2E7h7XBCBNK7OJ+OAx7Xkwn+yUb7o5p5GxExi4fzAw@mail.gmail.com>
 <0DCA82A4-7C10-40A7-AEF5-827171160FE8@gmail.com>
 <CAHGQGwEvA2a+jXZdVrdybX9OmWguSU4Q8wEhZxWKkDMOZHnuMQ@mail.gmail.com>
 <0C00CA35-D0C5-40EB-9C23-9F871DCE74E9@gmail.com>
 <2620a664-7b44-48b2-9aa8-5f0131702d9c@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/4FD8124D-6D42-4481-9C41-B658E5378364%40gmail.com>
Precedence: bulk


--Apple-Mail=_CF927418-4819-48BF-BF12-A1CBE8B7E881
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On May 28, 2026, at 01:56, Peter Eisentraut <peter@eisentraut.org> =
wrote:
>=20
> On 23.05.26 01:56, Chao Li wrote:
>>> On May 22, 2026, at 23:28, Fujii Masao <masao.fujii@gmail.com> =
wrote:
>>>=20
>>> On Fri, May 22, 2026 at 11:56=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>>> PFA v4, just removed conn NULL check.
>>>=20
>>> Thanks for updating the patch! I've pushed it.
>>>=20
>>> Regards,
>>>=20
>>> --=20
>>> Fujii Masao
>> Thanks for pushing and still working hard during the PGConf.
>=20
> The committed patch violates the .gitattributes whitespace rules:
>=20
> git show --check 06a5c3cdef02
>=20
> contrib/postgres_fdw/connection.c:651: indent with spaces.
> +                                                   /* expand_dbname =3D=
 */ false);
>=20
> It is unfortunate that pgindent produces this layout that contradicts =
the git configuration.  (The current formatting also doesn't look like =
what I would produce in an editor, so I think git is right here.)
>=20
> Maybe we could reformat this slightly to avoid that?  (unless someone =
wants to try to fix pgindent)
>=20
>=20

Ah, I was not aware of the whitespace rule. I think it was not pgindent; =
I made that change manually. I added =E2=80=9C=3D=E2=80=9D because I =
thought it might read more fluently.

Attached is a fix for that.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/


--Apple-Mail=_CF927418-4819-48BF-BF12-A1CBE8B7E881
Content-Disposition: attachment;
	filename=v1-0001-Fix-an-indentation-problem-in-postgres_fdw-connec.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="v1-0001-Fix-an-indentation-problem-in-postgres_fdw-connec.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=201fcadb474e54fe82eb0aa5f8d62ecd2dafede1dc=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20"Chao=20Li=20(Evan)"=20<lic@highgo.com>=0A=
Date:=20Thu,=2028=20May=202026=2008:30:22=20+0800=0ASubject:=20[PATCH=20=
v1]=20Fix=20an=20indentation=20problem=20in=20postgres_fdw/connection.c=0A=
=0AReported-by:=20Peter=20Eisentraut=20<peter@eisentraut.org>=0AAuthor:=20=
Chao=20Li=20<lic@highgo.com>=0AReviewed-by:=0ADiscussion:=20=
https://postgr.es/m/2620a664-7b44-48b2-9aa8-5f0131702d9c@eisentraut.org=0A=
---=0A=20contrib/postgres_fdw/connection.c=20|=202=20+-=0A=201=20file=20=
changed,=201=20insertion(+),=201=20deletion(-)=0A=0Adiff=20--git=20=
a/contrib/postgres_fdw/connection.c=20=
b/contrib/postgres_fdw/connection.c=0Aindex=20346f6f1fbfe..0810b756d38=20=
100644=0A---=20a/contrib/postgres_fdw/connection.c=0A+++=20=
b/contrib/postgres_fdw/connection.c=0A@@=20-648,7=20+648,7=20@@=20=
connect_pg_server(ForeignServer=20*server,=20UserMapping=20*user)=0A=20=0A=
=20=09=09/*=20OK=20to=20make=20connection=20*/=0A=20=09=09start_conn=20=3D=
=20libpqsrv_connect_params_start(keywords,=20values,=0A-=09=09=09=09=09=09=
=09=09=09=09=09=09=20=20=20=20/*=20expand_dbname=20=3D=20*/=20false);=0A=
+=09=09=09=09=09=09=09=09=09=09=09=09=20=20=20false=20/*=20expand_dbname=20=
*/=20);=0A=20=09=09PQsetNoticeReceiver(start_conn,=20=
libpqsrv_notice_receiver,=0A=20=09=09=09=09=09=09=09"received=20message=20=
via=20remote=20connection");=0A=20=09=09=
libpqsrv_connect_complete(start_conn,=20pgfdw_we_connect);=0A--=20=0A=
2.50.1=20(Apple=20Git-155)=0A=0A=

--Apple-Mail=_CF927418-4819-48BF-BF12-A1CBE8B7E881--