Message-ID: <4FDF7F54.5060406@enterprisedb.com>
Date: Mon, 18 Jun 2012 22:19:48 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:10.0.4) Gecko/20120510 Icedove/10.0.4
MIME-Version: 1.0
To: Andres Freund <andres@2ndquadrant.com>
CC: pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>
Subject: Re: WAL format changes
References: <4FDA5136.6080206@enterprisedb.com>
	<201206182013.12868.andres@2ndquadrant.com>
	<4FDF7456.9010709@enterprisedb.com>
	<201206182045.53962.andres@2ndquadrant.com>
In-Reply-To: <201206182045.53962.andres@2ndquadrant.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 18.06.2012 21:45, Andres Freund wrote:
> On Monday, June 18, 2012 08:32:54 PM Heikki Linnakangas wrote:
>> On 18.06.2012 21:13, Andres Freund wrote:
>>> On Monday, June 18, 2012 08:08:14 PM Heikki Linnakangas wrote:
>>>> The page header contains an XLogRecPtr (LSN), so if we change it we'll
>>>> have to deal with pg_upgrade. I guess we could still keep XLogRecPtr
>>>> around as the on-disk representation, and convert between the 64-bit
>>>> integer and XLogRecPtr in PageGetLSN/PageSetLSN. I can try that out -
>>>> many xlog calculations would admittedly be simpler if it was an uint64.
>>>
>>> I am out of my depth here, not having read any of the relevant code, but
>>> couldn't we simply replace the lsn from disk with InvalidXLogRecPtr
>>> without marking the page dirty?
>>>
>>> There is the valid argument that you would loose some information when
>>> pages with hint bits are written out again, but on the other hand you
>>> would also gain the information that it was a hint-bit write...
>>
>> Sorry, I don't understand that. Where would you "replace the LSN from
>> disk with InvalidXLogRecPtr" ? (and no, it probably won't work ;-) )
> In ReadBuffer_common or such, after reading a page from disk and verifying
> that the page has a valid header it seems to be possible to replace pd_lsn *in
> memory* by InvalidXLogRecPtr without marking the page dirty.
> If the page isn't modified the lsn on disk won't be changed so you don't loose
> debugging information in that case. If will be zero if it has been written by
> a hint-bit write and thats arguable a win.

We use the LSN to decide whether a full-page image need to be xlogged if 
the page is modified. If you reset LSN every time you read in a page, 
you'll be doing full page writes every time a page is read from disk and 
modified, whether or not it's the first time the page is modified after 
the last checkpoint.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com