Message-ID: <4FE8FDBE.8060901@enterprisedb.com>
Date: Tue, 26 Jun 2012 03:09:34 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:10.0.4) Gecko/20120510 Icedove/10.0.4
MIME-Version: 1.0
To: Robert Haas <robertmhaas@gmail.com>
CC: Fujii Masao <masao.fujii@gmail.com>,
	Andres Freund <andres@2ndquadrant.com>, pgsql-hackers@postgresql.org
Subject: Re: WAL format changes
References: <4FDA5136.6080206@enterprisedb.com>
	<201206142358.12431.andres@2ndquadrant.com>
	<CA+TgmobG9VWWvLXeK0XOxoWXtza8JTFgSu2eoAtVFucxH6gLBw@mail.gmail.com>
	<4FDF6E8E.4080900@enterprisedb.com>
	<4FE034D0.5070900@enterprisedb.com>
	<CA+TgmoZu=UMKLJDQ5FNRqPnomiGOSdEvzaj_Gg9CJzcPnvuxgQ@mail.gmail.com>
	<4FE73F3F.5040105@enterprisedb.com>
	<CAHGQGwHpdpPrmbq49yOp=zZTsiB+_cnwojRh0Xe9BE1D8fLegg@mail.gmail.com>
	<CAHGQGwGZo-hv2Fxm3LpCsh=mh1T_21mj7MKe35VQyBSZ6PsyVw@mail.gmail.com>
	<CA+TgmoZz=7xRhg389Qj=SwdVCvpK4VSpjJm_yg7WKQuUpk0wjw@mail.gmail.com>
In-Reply-To: 
 <CA+TgmoZz=7xRhg389Qj=SwdVCvpK4VSpjJm_yg7WKQuUpk0wjw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 25.06.2012 21:01, Robert Haas wrote:
> On Mon, Jun 25, 2012 at 1:57 PM, Fujii Masao<masao.fujii@gmail.com>  wrote:
>>> "<<" should be">>". The attached patch fixes this typo.
>>
>> Oh, I forgot to attach the patch.. Here is the patch.
>
> I committed both of the patches you posted to this thread.

Thanks Robert. I was thinking that "pg_resetxlog -l" would accept a WAL 
file name, instead of comma-separated tli, xlogid, segno arguments. The 
latter is a bit meaningless now that we don't use the xlogid+segno 
combination anywhere else. Alvaro pointed out that pg_upgrade was broken 
by the change in pg_resetxlog -n output - I changed that too to print 
the "First log segment after reset" information as a WAL file name, 
instead of logid+segno. Another option would be to print the 64-bit 
segment number, but I think that's worse, because the 64-bit 	segment 
number is harder to associate with a physical WAL file.

So I think we should change pg_resetxlog -l option to take a WAL file 
name as argument, and fix pg_upgrade accordingly.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com