Date: Wed, 25 Jan 2023 19:57:18 +0000
To: Justin Pryzby <pryzby@telsasoft.com>
From: gkokolatos@pm.me
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, Michael Paquier <michael@paquier.xyz>, pgsql-hackers@lists.postgresql.org, Rachel Heaton <rachelmheaton@gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
Message-ID: <4ZDVII-_kusch7xndcrTUt7OPSuQWQGX7n8rqp625Hdv6DijBjWZ38gjhxLSzPu8M_Dka-50eeKCiCU_dOdawwpv06dZtwGroYE9dHlIBLc=@pm.me>
In-Reply-To: <20230125180020.GF22427@telsasoft.com>
References: <IZzs7Z2ny5hRK1EhTynSg3DnCo_z-UvEJN4Q6Hf0CUHWx3BcNwt-2z5vvvvA-Z8PQL-AYiL9YQPlKylATZ_Z6HnJ55YZUHgL66H9MZQFi48=@pm.me> <d8cbc586-a8e3-1662-c158-9022d5c8de83@enterprisedb.com> <ce49a4f6-f7cc-28d7-3761-ddee7ef732af@enterprisedb.com> <MMLKPM28EzV5-NC4Jd3YdWCmPlUvbpbyqrugtklWTHZwF24g5x2IJ1J1wTICSESs8CaIRdj-56eDIqC4cTpahm55PmTVRik2D77X0ZKGeVo=@pm.me> <20230123180014.GX13860@telsasoft.com> <YiPrsNILgul-hbeyD6tfNaRUK5JZEhaZE36dLe1YJvKN_i0Tm2GuHd246MqcfNGFsjSY-rNo9n54MFCrRiRHRDkYyjgE4e29V-diAN2EcNU=@pm.me> <20230125014203.GL13860@telsasoft.com> <-myGeDiZ-ePDRyi18026Iu2HTTfmwfjWaJn4OWJ2F3oglZUfJTOQ7FARPW7gYxE4vK3b0HpwYoiHR45nfOWReRvvJZfCBfJzPP5iJyn4muk=@pm.me> <20230125180020.GF22427@telsasoft.com>
Feedback-ID: 6383013:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/4ZDVII-_kusch7xndcrTUt7OPSuQWQGX7n8rqp625Hdv6DijBjWZ38gjhxLSzPu8M_Dka-50eeKCiCU_dOdawwpv06dZtwGroYE9dHlIBLc%3D%40pm.me>
Precedence: bulk


------- Original Message -------
On Wednesday, January 25th, 2023 at 7:00 PM, Justin Pryzby <pryzby@telsasof=
t.com> wrote:


>=20
>=20
> On Wed, Jan 25, 2023 at 03:37:12PM +0000, gkokolatos@pm.me wrote:
>=20

> While looking at this, I realized that commit 5e73a6048 introduced a
> regression:
>=20
> @@ -3740,19 +3762,24 @@ ReadHead(ArchiveHandle *AH)
>=20
> - if (AH->compression !=3D 0)
>=20
> - pg_log_warning("archive is compressed, but this installation does not s=
upport compression -- no data will be available");
> + if (AH->compression_spec.algorithm =3D=3D PG_COMPRESSION_GZIP)
>=20
> + pg_fatal("archive is compressed, but this installation does not support=
 compression");
>=20
> Before, it was possible to restore non-data chunks of a dump file, even
> if the current build didn't support its compression. But that's now
> impossible - and it makes the code we're discussing in RestoreArchive()
> unreachable.

Nice catch!

Cheers,
//Georgios

> --
> Justin