Message-ID: <4a9c0545-6697-47d3-bf7c-2f5d0d7a7319@enterprisedb.com>
Date: Sat, 13 Apr 2024 11:19:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Parallel CREATE INDEX for BRIN indexes
To: Andres Freund <andres@anarazel.de>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CAEze2Wi9nWxx2wDTHaBJi36JLQ+-JcTU0BcRh+yd8AR-9VNxTw@mail.gmail.com>
 <c990c65c-93e9-f9c3-6792-02f929ce308f@enterprisedb.com>
 <CAEze2Wi1X=+M9=k2FUAL-b0rfvVK08q-x+-+wkam+T-8tcbgrw@mail.gmail.com>
 <c49dfd75-0a40-7feb-1018-54740e9a91db@enterprisedb.com>
 <CAEze2WiMsPZg=xkvSF_jt4=69k6K7gz5B8V2wY3gCGZ+1BzCbQ@mail.gmail.com>
 <99f9ecbe-0976-8012-67b5-dbff58c7dbec@enterprisedb.com>
 <CAEze2WjmoEo9UFpsiq_1sngOnZArjUMjN8wyzcQvegLFDddYUQ@mail.gmail.com>
 <32e3f645-389d-87f9-2ce7-33d0087f47d4@enterprisedb.com>
 <ff490ffe-6cf1-7168-d27c-cf89ed12cd09@enterprisedb.com>
 <3733d042-71e1-6ae6-5fac-00c12db62db6@enterprisedb.com>
 <20240413083635.47yve2c5pp2xt5b6@awork3.anarazel.de>
Content-Language: en-US
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: <20240413083635.47yve2c5pp2xt5b6@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/4a9c0545-6697-47d3-bf7c-2f5d0d7a7319%40enterprisedb.com>
Precedence: bulk

On 4/13/24 10:36, Andres Freund wrote:
> Hi,
> 
> While preparing a differential code coverage report between 16 and HEAD, one
> thing that stands out is the parallel brin build code. Neither on
> coverage.postgresql.org nor locally is that code reached during our tests.
>

Thanks for pointing this out, it's definitely something that I need to
improve (admittedly, should have been part of the patch). I'll also look
into eliminating the difference between BTREE and BRIN parallel builds,
mentioned in my last message in this thread.

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company