Subject: Re: Make mesage at end-of-recovery less scary.
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, michael@paquier.xyz
References: <20200228.160100.2210969269596489579.horikyota.ntt@gmail.com>
 <20200228073318.GD2688@paquier.xyz>
 <20200228.172806.1107809554616271723.horikyota.ntt@gmail.com>
 <20200305.160650.1027844943773682801.horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <4a9fc5b1-34c8-46ec-9b71-d4763d70311d@2ndquadrant.com>
Date: Mon, 23 Mar 2020 10:37:16 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200305.160650.1027844943773682801.horikyota.ntt@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-03-05 08:06, Kyotaro Horiguchi wrote:
> | [20866] LOG:  replication terminated by primary server
> | [20866] DETAIL:  End of WAL reached on timeline 1 at 0/30001C8.
> | [20866] FATAL:  could not send end-of-streaming message to primary: no COPY in progress
> | [20851] LOG:  reached end of WAL at 0/30001C8 on timeline 1 in archive during standby mode
> | [20851] DETAIL:  invalid record length at 0/30001C8: wanted 24, got 0
> 
> I changed the above to the below, which looks more adequate.
> 
> | [24271]  LOG:  replication terminated by primary server on timeline 1 at 0/3000240.
> | [24271]  FATAL:  could not send end-of-streaming message to primary: no COPY in progress
> | [24267]  LOG:  reached end of WAL at 0/3000240 on timeline 1 in archive during standby mode
> | [24267]  DETAIL:  invalid record length at 0/3000240: wanted 24, got 0

Is this the before and after?  That doesn't seem like a substantial 
improvement to me.  You still get the "scary" message at the end.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services