Message-ID: <4ab30d00-d434-4e82-af5d-260609075ff7@oss.nttdata.com>
Date: Fri, 2 Aug 2024 02:29:17 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [Proposal] Add foreign-server health checks infrastructure
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: 'Katsuragi Yuta' <katsuragiy@oss.nttdata.com>,
 'vignesh C' <vignesh21@gmail.com>, 'Ted Yu' <yuzhihong@gmail.com>,
 'Tom Lane' <tgl@sss.pgh.pa.us>,
 "'pgsql-hackers@lists.postgresql.org'" <pgsql-hackers@lists.postgresql.org>,
 =?UTF-8?B?J8OWbmRlciBLYWxhY8SxJw==?= <onderkalaci@gmail.com>,
 "'Shinya11.Kato@oss.nttdata.com'" <Shinya11.Kato@oss.nttdata.com>,
 'Kyotaro Horiguchi' <horikyota.ntt@gmail.com>,
 'Shubham Khanna' <khannashubham1197@gmail.com>
References: 
 <TYAPR01MB58669EAAC02493BFF9F39B06F5D99@TYAPR01MB5866.jpnprd01.prod.outlook.com>
 <OS3PR01MB9882E5D54A472AB0A5A098D8F58EA@OS3PR01MB9882.jpnprd01.prod.outlook.com>
 <be9382f7-5072-4760-8b3f-31d6dffa8d62@oss.nttdata.com>
 <TYAPR01MB56923ACAE33FD04A3560F413F5AC2@TYAPR01MB5692.jpnprd01.prod.outlook.com>
 <613adbf9-c86e-41dc-ab97-27dc4e7281c7@oss.nttdata.com>
 <TYCPR01MB56933FCF37A676B868362575F5AA2@TYCPR01MB5693.jpnprd01.prod.outlook.com>
 <d04aae8d-05f5-42f4-a263-b962334d9f75@oss.nttdata.com>
 <TYCPR01MB569331643314B5129312C332F5B42@TYCPR01MB5693.jpnprd01.prod.outlook.com>
 <TYCPR01MB56934DE73B0AF7A37D8CF7B2F5B42@TYCPR01MB5693.jpnprd01.prod.outlook.com>
 <768032ee-fb57-494b-b674-1ccb65b6f969@oss.nttdata.com>
 <TYCPR01MB5693504C160299B2031FA6FFF5B42@TYCPR01MB5693.jpnprd01.prod.outlook.com>
 <1aa89c91-e3f1-4071-9fa9-14bffa600dd2@oss.nttdata.com>
 <TYAPR01MB5692411E16AB98D8CF72C2E7F5B72@TYAPR01MB5692.jpnprd01.prod.outlook.com>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: 
 <TYAPR01MB5692411E16AB98D8CF72C2E7F5B72@TYAPR01MB5692.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4ab30d00-d434-4e82-af5d-260609075ff7%40oss.nttdata.com>
Precedence: bulk


On 2024/07/29 12:58, Hayato Kuroda (Fujitsu) wrote:
> Dear Fujii-san,
> 
>>> IIUC, the patch which adds user_name attribute to get_connection() can be
>> discussed
>>> in later stage, is it right?
>>
>> No, let's work on the patch at this stage :)
> 
> OK, here is a rebased patch.

Thanks for updating the patch!

> - Changed the name of new API from `GetUserMappingFromOid` to `GetUserMappingByOid`
>    to keep the name consistent with others.

If we expose this function as an FDW helper function, it should return
a complete UserMapping object, including umoptions.

However, if postgres_fdw_get_connections() is the only user of this function,
I'm not inclined to expose it as an FDW helper. Instead, we can either get
the user ID by user mapping OID directly in connection.c using SearchSysCache(),
or add the user ID to ConnCacheEntry and use it in postgres_fdw_get_connections().
Thought?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION