Subject: Re: allow online change primary_conninfo
To: Sergei Kornilov <sk@zsrv.org>, Alvaro Herrera <alvherre@2ndquadrant.com>
References: <20200327195149.GA32145@alvherre.pgsql>
 <20200327233911.GA30735@alvherre.pgsql>
 <3109511585392143@myt6-887fb48a9c29.qloud-c.yandex.net>
Cc: Michael Paquier <michael@paquier.xyz>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 "andres@anarazel.de" <andres@anarazel.de>,
 "david@pgmasters.net" <david@pgmasters.net>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <4b1bfe72-43ab-60ca-5b29-afc23f1726e7@2ndquadrant.com>
Date: Wed, 1 Apr 2020 16:03:05 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <3109511585392143@myt6-887fb48a9c29.qloud-c.yandex.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-03-28 11:49, Sergei Kornilov wrote:
> I attached updated patch: walreceiver will use configured primary_slot_name as temporary slot name if wal_receiver_create_temp_slot is enabled.

The original setup worked consistently with pg_basebackup.  In 
pg_basebackup, if you specify -S/--slot, then it uses a permanent slot 
with the given name.  This is the same behavior as primary_slot_name has 
now.  We should be careful that we don't create two sets of 
options/settings that look similar but combine in different ways.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services