Subject: Re: row filtering for logical replication
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Ajin Cherian <itsajin@gmail.com>, Euler Taveira <euler@eulerto.com>,
 Peter Smith <smithpb2250@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 =?UTF-8?B?w5ZuZGVyIEthbGFjxLE=?= <onderkalaci@gmail.com>,
 japin <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>,
 David Steele <david@pgmasters.net>, Craig Ringer <craig@2ndquadrant.com>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Amit Langote <amitlangote09@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CA+HiwqH+9NK5m-=BOYpzjH5UEpeWjT_3HEm4XBYNrda88naGMQ@mail.gmail.com>
 <CAHut+Pvn+S8upyrkBi3m=rc4b5Ttw3xGsg09rNec=qJK0pD5mQ@mail.gmail.com>
 <CAA4eK1J1FNhDhj85Am1X_5VTxKOYo_nSBMuuMteB3n5YVPMdpw@mail.gmail.com>
 <CAHut+PtbKUmWNjTEDMVhP9abjgph6JB7vUFYF7ioa_4uRPZb=A@mail.gmail.com>
 <CAA4eK1LPhubcm4o1Xg0RwZdatqwfz3KKYcdun8QvRyqFthyJ1g@mail.gmail.com>
 <CAHut+PtFxoP477E8odkxkpyDoH_tiNBSiJH-j88NR728nxPErQ@mail.gmail.com>
 <CAA4eK1+tio46goUKBUfAKFsFVxtgk8nOty=TxKoKH-gdLzHD2g@mail.gmail.com>
 <CAHut+PtdRU74kUZd2RugdCqB0Ya1L+BbZk45czM5ufQs5E8jmw@mail.gmail.com>
 <CAHut+PsgRHymwLhJ9t3By6+KNaVDzfjf6Y4Aq=JRD-y8t1mEFg@mail.gmail.com>
 <0c2464d4-65f4-4d91-aeb2-c5584c1350f5@www.fastmail.com>
 <CAFPTHDb7bpkuc4SxaL9B5vEvF2aEi0EOERdrG+xgVeAyMJsF=Q@mail.gmail.com>
 <CAFPTHDYZk4P1kD=y6qMBnzh66+CgnfV3VTK7yS-Tk1eGrFOVZg@mail.gmail.com>
 <574b4e78-2f35-acf3-4bdc-4b872582e739@enterprisedb.com>
 <CAA4eK1KrEFzFc42EvdNVpFRE9sWnQq1Gswpm9ewhKGy5vnrbUw@mail.gmail.com>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
Message-ID: <4b213b91-8428-85a7-7ed6-48ceefd7f7be@enterprisedb.com>
Date: Fri, 24 Sep 2021 23:37:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: 
 <CAA4eK1KrEFzFc42EvdNVpFRE9sWnQq1Gswpm9ewhKGy5vnrbUw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4b213b91-8428-85a7-7ed6-48ceefd7f7be%40enterprisedb.com>
Precedence: bulk


On 9/24/21 8:09 AM, Amit Kapila wrote:
> On Thu, Sep 23, 2021 at 6:03 PM Tomas Vondra
> <tomas.vondra@enterprisedb.com> wrote:
>>
>> 13) turning update into insert
>>
>> I agree with Ajin Cherian [4] that looking at just old or new row for
>> updates is not the right solution, because each option will "break" the
>> replica in some case. So I think the goal "keeping the replica in sync"
>> is the right perspective, and converting the update to insert/delete if
>> needed seems appropriate.
>>
>> This seems a somewhat similar to what pglogical does, because that may
>> also convert updates (although only to inserts, IIRC) when handling
>> replication conflicts. The difference is pglogical does all this on the
>> subscriber, while this makes the decision on the publisher.
>>
>> I wonder if this might have some negative consequences, or whether
>> "moving" this to downstream would be useful for other purposes in the
>> fuure (e.g. it might be reused for handling other conflicts).
>>
> 
> Apart from additional traffic, I am not sure how will we handle all
> the conditions on subscribers, say if the new row doesn't match, how
> will subscribers know about this unless we pass row_filter or some
> additional information along with tuple. Previously, I have done some
> research and shared in one of the emails above that IBM's InfoSphere
> Data Replication [1] performs filtering in this way which also
> suggests that we won't be off here.
> 

I'm certainly not suggesting what we're doing is wrong. Given the design 
of built-in logical replication it makes sense doing it this way, I was 
just thinking aloud about what we might want to do in the future (e.g. 
pglogical uses this to deal with conflicts between multiple sources, and 
so on).

>>
>>
>> 15) pgoutput_row_filter initializing filter
>>
>> I'm not sure I understand why the filter initialization gets moved from
>> get_rel_sync_entry. Presumably, most of what the replication does is
>> replicating rows, so I see little point in not initializing this along
>> with the rest of the rel_sync_entry.
>>
> 
> Sorry, IIRC, this has been suggested by me and I thought it was best
> to do any expensive computation the first time it is required. I have
> shared few cases like in [2] where it would lead to additional cost
> without any gain. Unless I am missing something, I don't see any
> downside of doing it in a delayed fashion.
> 

Not sure, but the arguments presented there seem a bit wonky ...

Yes, the work would be wasted if we discard the cached data without 
using it (it might happen for truncate, I'm not sure). But how likely is 
it that such operations happen *in isolation*? I'd bet the workload is 
almost never just a stream of truncates - there are always some 
operations in between that would actually use this.

Similarly for the errors - IIRC hitting an error means the replication 
restarts, which is orders of magnitude more expensive than anything we 
can save by this delayed evaluation.

I'd keep it simple, for the sake of simplicity of the whole patch.

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company