Feedback-ID: i131946ab:Fastmail
Message-ID: <4b856bab-c37b-559e-1ab6-68f189146013@enterprisedb.com>
Date: Wed, 6 Jul 2022 08:51:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: refactor some protocol message sending in walsender and
 basebackup
Content-Language: en-US
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <7e4fdbdc-699c-4cd0-115d-fb78a957fc22@enterprisedb.com>
 <20220701213646.GA582729@nathanxps13>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220701213646.GA582729@nathanxps13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4b856bab-c37b-559e-1ab6-68f189146013%40enterprisedb.com>
Precedence: bulk

On 01.07.22 23:36, Nathan Bossart wrote:
> On Thu, Jun 23, 2022 at 04:36:36PM +0200, Peter Eisentraut wrote:
>> Some places in walsender.c and basebackup_copy.c open-code the sending of
>> RowDescription and DataRow protocol messages.  But there are already more
>> compact and robust solutions available for this, using DestRemoteSimple and
>> associated machinery, already in use in walsender.c.
>>
>> The attached patches 0001 and 0002 are tiny bug fixes I found during this.
>>
>> Patches 0003 and 0004 are the main refactorings.  They should probably be
>> combined into one patch eventually, but this way the treatment of
>> RowDescription and DataRow is presented separately.
> 
> All 4 patches look reasonable to me.

All committed now, thanks.

(I cleaned up the 0004 patch a bit more; there was some junk left in the 
posted patch.)