Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wFOjg-0053TR-0z
	for pgsql-hackers@arkaria.postgresql.org;
	Wed, 22 Apr 2026 03:58:48 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wFOje-00Babb-1t
	for pgsql-hackers@arkaria.postgresql.org;
	Wed, 22 Apr 2026 03:58:46 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <quanzongliang@yeah.net>)
	id 1wFOjd-00BaaW-27
	for pgsql-hackers@lists.postgresql.org;
	Wed, 22 Apr 2026 03:58:46 +0000
Received: from mail-m16.yeah.net ([220.197.32.19])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <quanzongliang@yeah.net>)
	id 1wFOjQ-00000002PXO-2Ely
	for pgsql-hackers@postgresql.org;
	Wed, 22 Apr 2026 03:58:38 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net;
	s=s110527; h=Message-ID:Date:MIME-Version:Subject:To:From:
	Content-Type; bh=ywpkc+0h5GMs4oPDE20BxvSvUSUS4LurgYJ2EIE49y4=;
	b=NngtAb8B1Ker4RulgFTXtM5UAOgn1GCsem6dFeuuFG5eIAaGsF8QFM0m8BCJ3+
	4TsGHlgOeqAFP/roUlQyy6Lns0iw2wvpKwDKhow3thdtz0NSl3oVp2fAv3l9UsTz
	Z6gzfNn/02hxKmR/OvRM87LkGZdSLvscf2LHWoNo72mok=
Received: from [IPV6:2408:8210:3c44:f620:921:b74c:584d:8b4] (unknown [])
	by gzsmtp2 (Coremail) with UTF8SMTPA id Ms8vCgAHLxZgR+hpDULXAQ--.8500S2;
	Wed, 22 Apr 2026 11:58:25 +0800 (CST)
Message-ID: <4bbd4e09-dc4a-400d-ae7a-7bea030acc39@yeah.net>
Date: Wed, 22 Apr 2026 11:58:24 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Remove dead code in ExecForPortionOfLeftovers()
To: Aleksander Alekseev <aleksander@tigerdata.com>,
 PostgreSQL Development <pgsql-hackers@postgresql.org>
References: 
 <CAJ7c6TN9ETkTxdcwuexovXrXdpNWcxzQ7iiTes+_xpEWC5xO0Q@mail.gmail.com>
Content-Language: en-US
From: Quan Zongliang <quanzongliang@yeah.net>
In-Reply-To: 
 <CAJ7c6TN9ETkTxdcwuexovXrXdpNWcxzQ7iiTes+_xpEWC5xO0Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-CM-TRANSID: Ms8vCgAHLxZgR+hpDULXAQ--.8500S2
X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73
	VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxU4eHDDUUUU
X-Originating-IP: [2408:8210:3c44:f620:921:b74c:584d:8b4]
X-CM-SenderInfo: htxd06xrqjzxxdqjq5hhdkh0dhw/1tbiIgF+omnoR2GRfQAA30
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/4bbd4e09-dc4a-400d-ae7a-7bea030acc39%40yeah.net>
Precedence: bulk



On 4/21/26 8:22 PM, Aleksander Alekseev wrote:
> Hi,
> 
> While reading 8e72d914c528 I noticed that
> ForPortionOfState.fp_leftoverstypcache is not used for anything. I
> suggest removing it, as attached.
> 

Agree.
It indeed did not make any reference anywhere.

Quan Zongliang