Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmHCU-0006o4-Mu for pgsql-hackers@arkaria.postgresql.org; Wed, 04 May 2022 15:46:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHCT-00070i-Jq for pgsql-hackers@arkaria.postgresql.org; Wed, 04 May 2022 15:46:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmHCT-00070U-A9 for pgsql-hackers@lists.postgresql.org; Wed, 04 May 2022 15:46:01 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmHCQ-0001Nv-Qx for pgsql-hackers@postgresql.org; Wed, 04 May 2022 15:46:00 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5C27F5C01A1; Wed, 4 May 2022 11:45:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 04 May 2022 11:45:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1651679157; x=1651765557; bh=zAcOCvlG+N3bH YLFZTqQkfsNbHHnk0f2bSrZAPmzSwk=; b=mh0j2ySly/dQ4/Nz5L2xwMhIc6+S6 1/1wDNMz06hTME2rMaJX5PpfF+Jdl+YtwAb9Qx1IzxM1k/drvwcxdneKVRw5Ajru NbU8D8MamVozc8tDL4crZ57eR/EGxkgolCDjw+ssIctE3JVPuE1FmCCHWsckGkud FOWCjJGhdM9Z4qBElOS+74bPtn+unPfFLGsUhF+V+2/qe8r2Tc8fXppy3wGBGcuZ lwEh/jEoUwjfImDu2BeeqINnyL7LElcqzHlr31CYS369bGKGWrFEqj9QWNI4eBcv 758/VvpEca3rXKr3MSur0lq/SN/DWvlTOrQAwKyB1amwgt79nORkRGGcQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdelgdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvg hrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepheelffeggedujeetiefh leetuddvieffhfffvdejvdffgeejkeduleduheduieefnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht segvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 May 2022 11:45:56 -0400 (EDT) Message-ID: <4c0d7a26-974d-7196-5700-0fa726289051@enterprisedb.com> Date: Wed, 4 May 2022 17:45:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: automatically generating node support functions Content-Language: en-US To: Alvaro Herrera Cc: Tom Lane , pgsql-hackers References: <202204191140.3wsbevfhqmu3@alvherre.pgsql> From: Peter Eisentraut In-Reply-To: <202204191140.3wsbevfhqmu3@alvherre.pgsql> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 19.04.22 13:40, Alvaro Herrera wrote: > I rebased this mostly out of curiousity. I fixed some smallish > conflicts and fixed a typedef problem new in JSON support; however, even > with these fixes it doesn't compile, because JsonPathSpec uses a novel > typedef pattern that apparently will need bespoke handling in the > gen_nodes_support.pl script. It seemed better to post this even without > that, though. I have committed your change to the JsonTableColumnType enum and the removal of JsonPathSpec. Other than that and some whitespace changes, I didn't find anything in your 0002 patch that was different from my last submitted patch. Did I miss anything?