Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdJZx-0005gC-Bo for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Feb 2017 16:34:17 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cdJZw-0003mN-Rk for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Feb 2017 16:34:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cdJZv-0003jv-I0 for pgsql-hackers@postgresql.org; Mon, 13 Feb 2017 16:34:15 +0000 Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cdJZr-0005Nm-A7 for pgsql-hackers@postgresql.org; Mon, 13 Feb 2017 16:34:14 +0000 Received: by mail-qk0-x22a.google.com with SMTP id s186so98739037qkb.1 for ; Mon, 13 Feb 2017 08:34:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=92Aemyrw32R3kafhQm9Rp/sp/wZBkN30UBT50qHj+e4=; b=McHfCFNo9/lCKEyvDdKX9xo6ykXggqDEUADQw96OPGN23Y1LbUEETJClaYJdrO6Rst RkAOf3NGPwM3TDQ8tmV3rXU5yApUvhct+afNvQBvVVuM5Dt5nMZl/rc3eYBTL2ZM3J+4 47tf+/1FwcEWmhLMEGKTbZIIKSb8u73CLotq3jEczfbCRIv0s6FNO1R9eumqvaqP/J40 vW0P09e2avHvqCDbnw4TNtB+QA51+R7CScmYdyUuoCHu9rOgTdgeyIW8Liaq8c5Lhs2k DyjWBJ2Dsj4+k3tVJvqcaGV9u/nRMRXvEVCMbaOKjA8xdoYuoFFLNDX07qed09IPQG7o ldNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=92Aemyrw32R3kafhQm9Rp/sp/wZBkN30UBT50qHj+e4=; b=CnOeJ0OOciH+B6XAVoB680bcynOSs27cjpHP2QG7ZLOayjgGbBXkdFCECuvMl7yvp6 xY1HYoI9oqK44UHQz3DSVDIWsYIeYV/6TRPB82Z4AAfoW5c8XHgKFUnvJg521P3klNWR AZYvMkM93l5fvESng3L1ej7NhZ6gMxQL1vSuy+C4uDXIZtxcszFj54hsblHApnaeIGky BFY0eQGZr807sYiHksnWYW7WzKWMVMemtNKeHEdkOs7729tSAkAZqdmDr5S4oGqgrI1P BUwB7hIhVM7cxJI180+dJk+S0+pvVgAPVLBA2sk81HwoaBMYO9kk1swiAwmQRKXYhASp 7aLw== X-Gm-Message-State: AMke39mpfJshlqQ7uQbdrz386pbZoR28REb3FbCRCXd1fMbkBZ59g5j5oLPYkjESrPk5KxdZC+kPTpJRM6Jtngd9u4JN7iQz0GLdmdZAO+E4v3R907cD4T0WEmGJD358THC4pOSD8UY4axI9G15oQAQ1LpO7BIA4WQrhgyWRuhJdRuJBwfGJBH5mXUX8gStJXmmThaTxSRZMG2s= X-Received: by 10.55.68.20 with SMTP id r20mr24388640qka.213.1487003649646; Mon, 13 Feb 2017 08:34:09 -0800 (PST) Received: from [192.168.10.146] ([98.122.164.227]) by smtp.gmail.com with ESMTPSA id b190sm7803966qkg.32.2017.02.13.08.34.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Feb 2017 08:34:08 -0800 (PST) From: Andrew Dunstan X-Google-Original-From: Andrew Dunstan Subject: Re: IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements To: Anastasia Lubennikova , pgsql-hackers References: <7c2ab9b8-388a-1ce0-23a3-7acf2a0ed3c6@postgrespro.ru> Message-ID: <4c7d935a-397d-16fe-c604-5e398cc1fc03@2ndQuadrant.com> Date: Mon, 13 Feb 2017 11:34:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <7c2ab9b8-388a-1ce0-23a3-7acf2a0ed3c6@postgrespro.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 01/13/2017 08:36 AM, Anastasia Lubennikova wrote: > I implemented IF NOT EXISTS option for CREATE SERVER and CREATE USER > MAPPING statements > for one of our customers. > I think other users can also find it useful for scripting and > automated tasks. > The patches themselves are small and simple. Documentation is updated > as well. > This looks good and useful. Please add some regression tests. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers