Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdYZz-000330-Lo for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Oct 2021 13:57:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mdYZy-0007io-Iu for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Oct 2021 13:57:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdYZy-0007ie-Ak for pgsql-hackers@lists.postgresql.org; Thu, 21 Oct 2021 13:57:58 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdYZv-0006rk-7b for pgsql-hackers@lists.postgresql.org; Thu, 21 Oct 2021 13:57:57 +0000 Received: from hrk.local (p2388012-ipbf1027funabasi.chiba.ocn.ne.jp [118.6.6.12]) by oss.nttdata.com (Postfix) with ESMTPSA id 9E0DF60914 for ; Thu, 21 Oct 2021 22:57:50 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.3 at oss.nttdata.com To: PostgreSQL Hackers From: Fujii Masao Subject: wait event and archive_command Message-ID: <4ca4f920-6b48-638d-08b2-93598356f5d3@oss.nttdata.com> Date: Thu, 21 Oct 2021 22:57:50 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------CD30D53E96AE1CEC7AA672B3" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------CD30D53E96AE1CEC7AA672B3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi, I'd like to propose to add new wait event reported while archiver process is executing archive_command. This would be helpful to observe what archiver is doing and check whether it has some troubles or not. Thought? PoC patch attached. Also how about adding wait events for other commands like archive_cleanup_command, restore_command and recovery_end_command? Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------CD30D53E96AE1CEC7AA672B3 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="wait_event_for_archive_command_v1.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="wait_event_for_archive_command_v1.patch" ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwgYi9kb2Mvc3JjL3Nn bWwvbW9uaXRvcmluZy5zZ21sCmluZGV4IDMxNzNlYzI1NjYuLjEzYzdlOTkxZDAgMTAwNjQ0 Ci0tLSBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21s L21vbml0b3Jpbmcuc2dtbApAQCAtMTU2OSw3ICsxNTY5LDEyIEBAIHBvc3RncmVzICAgMjcw OTMgIDAuMCAgMC4wICAzMDA5NiAgMjc1MiA/ICAgICAgICBTcyAgIDExOjM0ICAgMDowMCBw b3N0Z3Jlczogc2VyCiAgICAgICA8ZW50cnk+V2FpdGluZyBmb3Igc3VicGxhbiBub2RlcyBv ZiBhbiA8bGl0ZXJhbD5BcHBlbmQ8L2xpdGVyYWw+IHBsYW4KICAgICAgICBub2RlIHRvIGJl IHJlYWR5LjwvZW50cnk+CiAgICAgIDwvcm93PgotICAgIDxyb3c+CisgICAgIDxyb3c+Cisg ICAgICA8ZW50cnk+PGxpdGVyYWw+QXJjaGl2ZUNvbW1hbmQ8L2xpdGVyYWw+PC9lbnRyeT4K KyAgICAgIDxlbnRyeT5XYWl0aW5nIGZvciA8eHJlZiBsaW5rZW5kPSJndWMtYXJjaGl2ZS1j b21tYW5kIi8+IHRvCisgICAgICAgY29tcGxldGUuPC9lbnRyeT4KKyAgICAgPC9yb3c+Cisg ICAgIDxyb3c+CiAgICAgICA8ZW50cnk+PGxpdGVyYWw+QmFja2VuZFRlcm1pbmF0aW9uPC9s aXRlcmFsPjwvZW50cnk+CiAgICAgICA8ZW50cnk+V2FpdGluZyBmb3IgdGhlIHRlcm1pbmF0 aW9uIG9mIGFub3RoZXIgYmFja2VuZC48L2VudHJ5PgogICAgICA8L3Jvdz4KZGlmZiAtLWdp dCBhL3NyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvcGdhcmNoLmMgYi9zcmMvYmFja2VuZC9wb3N0 bWFzdGVyL3BnYXJjaC5jCmluZGV4IDc0YTdkN2M0ZDAuLjIyMDFmMDY5ZWEgMTAwNjQ0Ci0t LSBhL3NyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvcGdhcmNoLmMKKysrIGIvc3JjL2JhY2tlbmQv cG9zdG1hc3Rlci9wZ2FyY2guYwpAQCAtNTE1LDcgKzUxNSwxMCBAQCBwZ2FyY2hfYXJjaGl2 ZVhsb2coY2hhciAqeGxvZykKIAlzbnByaW50ZihhY3Rpdml0eW1zZywgc2l6ZW9mKGFjdGl2 aXR5bXNnKSwgImFyY2hpdmluZyAlcyIsIHhsb2cpOwogCXNldF9wc19kaXNwbGF5KGFjdGl2 aXR5bXNnKTsKIAorCXBnc3RhdF9yZXBvcnRfd2FpdF9zdGFydChXQUlUX0VWRU5UX0FSQ0hJ VkVfQ09NTUFORCk7CiAJcmMgPSBzeXN0ZW0oeGxvZ2FyY2hjbWQpOworCXBnc3RhdF9yZXBv cnRfd2FpdF9lbmQoKTsKKwogCWlmIChyYyAhPSAwKQogCXsKIAkJLyoKZGlmZiAtLWdpdCBh L3NyYy9iYWNrZW5kL3V0aWxzL2FjdGl2aXR5L3dhaXRfZXZlbnQuYyBiL3NyYy9iYWNrZW5k L3V0aWxzL2FjdGl2aXR5L3dhaXRfZXZlbnQuYwppbmRleCA0YTViNzUwMmY1Li5kOGUzNjg4 YWI1IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9hY3Rpdml0eS93YWl0X2V2ZW50 LmMKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvYWN0aXZpdHkvd2FpdF9ldmVudC5jCkBAIC0z MTMsNiArMzEzLDkgQEAgcGdzdGF0X2dldF93YWl0X2lwYyhXYWl0RXZlbnRJUEMgdykKIAkJ Y2FzZSBXQUlUX0VWRU5UX0FQUEVORF9SRUFEWToKIAkJCWV2ZW50X25hbWUgPSAiQXBwZW5k UmVhZHkiOwogCQkJYnJlYWs7CisJCWNhc2UgV0FJVF9FVkVOVF9BUkNISVZFX0NPTU1BTkQ6 CisJCQlldmVudF9uYW1lID0gIkFyY2hpdmVDb21tYW5kIjsKKwkJCWJyZWFrOwogCQljYXNl IFdBSVRfRVZFTlRfQkFDS0VORF9URVJNSU5BVElPTjoKIAkJCWV2ZW50X25hbWUgPSAiQmFj a2VuZFRlcm1pbmF0aW9uIjsKIAkJCWJyZWFrOwpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUv dXRpbHMvd2FpdF9ldmVudC5oIGIvc3JjL2luY2x1ZGUvdXRpbHMvd2FpdF9ldmVudC5oCmlu ZGV4IGMyMjE0MjM2NWYuLjJlZGZkZDNlNTEgMTAwNjQ0Ci0tLSBhL3NyYy9pbmNsdWRlL3V0 aWxzL3dhaXRfZXZlbnQuaAorKysgYi9zcmMvaW5jbHVkZS91dGlscy93YWl0X2V2ZW50LmgK QEAgLTgwLDYgKzgwLDcgQEAgdHlwZWRlZiBlbnVtCiB0eXBlZGVmIGVudW0KIHsKIAlXQUlU X0VWRU5UX0FQUEVORF9SRUFEWSA9IFBHX1dBSVRfSVBDLAorCVdBSVRfRVZFTlRfQVJDSElW RV9DT01NQU5ELAogCVdBSVRfRVZFTlRfQkFDS0VORF9URVJNSU5BVElPTiwKIAlXQUlUX0VW RU5UX0JBQ0tVUF9XQUlUX1dBTF9BUkNISVZFLAogCVdBSVRfRVZFTlRfQkdXT1JLRVJfU0hV VERPV04sCg== --------------CD30D53E96AE1CEC7AA672B3--