Reply-To: jesper.pedersen@redhat.com
Subject: Re: [HACKERS] MERGE SQL Statement for PG11
From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Simon Riggs <simon@2ndquadrant.com>,
 Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Amit Langote
 <Langote_Amit_f8@lab.ntt.co.jp>, Robert Haas <robertmhaas@gmail.com>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
 Pavan Deolasee <pavan.deolasee@2ndquadrant.com>,
 Stephen Frost <sfrost@snowman.net>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: 
 <CAH2-WzkJdBuxj9PO=2QaO9-3h3xGbQPZ34kJH=HukRekwM-GZg@mail.gmail.com>
 <CA+Tgmoam1LtX7KDstYfduQycksPQEu3EeVnayfCB=U7sORGOpg@mail.gmail.com>
 <CA+TgmoZbPMEuEyeL8xOep-MdpYsQNutqhY7j-J3m4k2Xran+uA@mail.gmail.com>
 <CANP8+jKxrNcZX1WBoVLdNKJuQj4g4PyVKLF9ie+Rvae9ONvimw@mail.gmail.com>
 <CABOikdM9hvMCt_nsunLpk1KhQQVwW+-cGH7BfMoh4HqMdbbn-g@mail.gmail.com>
 <CANP8+jKLyN4+qcH7wVR0h-qYCYine3L6x0-a8rD6SajJY-k3XQ@mail.gmail.com>
 <CABOikdOwA4+CJO4MwzF250huNuBWejWugf-GZwrbX-k=NDc2rw@mail.gmail.com>
 <CAH2-WzkNY4o2q_kJGNNqjExcPy=nmFgNn_MvgTXhUOxQw-jyJw@mail.gmail.com>
 <CABOikdMO4G3dBL9HSzP9DBT051uGnd0uejnYAEZk+iYn3AWY2g@mail.gmail.com>
 <CANP8+jLKcQP1Sft5qEZMpHCu7fUD-0vYHRYjcJZAepWjBPz4ng@mail.gmail.com>
 <CANP8+jJj=SHbn3dcOTAhj8gdSgiEwHAMU4Gx=GkRu-zhjhKmig@mail.gmail.com>
 <a1946413-cac0-3d1c-17d6-ccff2aa4fccc@redhat.com>
Organization: Red Hat
Message-ID: <4cccec00-bf86-1989-bb59-05e57ad3d2a1@redhat.com>
Date: Thu, 5 Apr 2018 07:38:07 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <a1946413-cac0-3d1c-17d6-ccff2aa4fccc@redhat.com>
Content-Type: multipart/mixed;
 boundary="------------52DDFA7F992293BE1A689336"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------52DDFA7F992293BE1A689336
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Simon and Paven,

On 04/04/2018 08:46 AM, Jesper Pedersen wrote:
> On 03/30/2018 07:10 AM, Simon Riggs wrote:
>> No problems found, but moving proposed commit to 2 April pm
>>
> 
> There is a warning for this, as attached.
> 

Updated version due to latest refactoring.

Best regards,
   Jesper


--------------52DDFA7F992293BE1A689336
Content-Type: text/x-patch;
 name="merge_warn_v2.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="merge_warn_v2.patch"

diff --git a/src/backend/executor/execMerge.c b/src/backend/executor/execMerge.c
index 471f64361d..e35025880d 100644
--- a/src/backend/executor/execMerge.c
+++ b/src/backend/executor/execMerge.c
@@ -48,7 +48,6 @@ ExecMerge(ModifyTableState *mtstate, EState *estate, TupleTableSlot *slot,
 	ItemPointer tupleid;
 	ItemPointerData tuple_ctid;
 	bool		matched = false;
-	char		relkind;
 	Datum		datum;
 	bool		isNull;
 

--------------52DDFA7F992293BE1A689336--